Automate prebuilt executable updates via GitHub Actions #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vacantron
force-pushed
the
prebuilt
branch
7 times, most recently
from
bec637f to
4721508
Compare
jserv
reviewed
Aug 17, 2024
jserv
reviewed
Aug 17, 2024
jserv
reviewed
Aug 17, 2024
jserv
reviewed
Aug 17, 2024
jserv
reviewed
Aug 17, 2024
jserv
reviewed
Aug 17, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
It is a bit confusing that |
No, the original |
jserv
reviewed
Aug 17, 2024
jserv
reviewed
Aug 17, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
ChinYikMing
reviewed
Aug 21, 2024
|
Thank @vacantron for contributing! |
ChinYikMing
added a commit
to ChinYikMing/rv32emu
that referenced
this pull request
Sep 1, 2024
After merging sysprog21#474, multiple executables were moved to other locations (e.g., build/riscv32), causing the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered. Related: sysprog21#486
Merged
ChinYikMing
added a commit
to ChinYikMing/rv32emu
that referenced
this pull request
Sep 1, 2024
After merging sysprog21#474, multiple executables were moved to other location (build/riscv32), which caused the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Also, executables that stored in rv32emu-prebuilt must be pulled before embedding into wasm, so emcc_deps should depend on the artifact target. Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered. Related: sysprog21#486
ChinYikMing
added a commit
to ChinYikMing/rv32emu
that referenced
this pull request
Sep 2, 2024
After merging sysprog21#474, multiple executables were moved to other location (build/riscv32), which caused the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Also, executables that stored in rv32emu-prebuilt must be pulled before embedding into wasm, so emcc_deps should depend on the artifact target. Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered. Related: sysprog21#486
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Automate prebuilt executable updates via GitHub Actions
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
After merging sysprog21#474, multiple executables were moved to other location (build/riscv32), which caused the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Also, executables that stored in rv32emu-prebuilt must be pulled before embedding into wasm, so emcc_deps should depend on the artifact target. Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered. Related: sysprog21#486
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the executables up to date for testing and benchmarking, this pull request introduces GitHub CI/CD pipeline to release the tarball of the latest executables when the files under
tests/be changed.Close #451