Move artifact target under emcc build condition #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normal 'make' or 'make all' does not require downloading prebuilt ELF executables from the rv32emu-prebuilt repo. However, 'deps_emcc' always depends on the 'artifact' target, even when not using emcc, causing 'make' or 'make all' to always download prebuilt ELF executables. To prevent this, the 'artifact' target is moved under the emcc build condition. Related: sysprog21#491
vacantron
approved these changes
Sep 6, 2024
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Move artifact target under emcc build condition
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal 'make' or 'make all' does not require downloading prebuilt ELF executables from the rv32emu-prebuilt repo. However, 'deps_emcc' always depends on the 'artifact' target, even when not using emcc, causing 'make' or 'make all' to always download prebuilt ELF executables. To prevent this, the 'artifact' target is moved under the emcc build condition.
Related: #491