-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Avoid repeated downloads for assets during test #491
Comments
@ChinYikMing, can you remove this line as the object file dependencies which added in #487? This will always trigger rebuilding Line 222 in 563af8b
|
I would prefer to keep it and only add the Line 2 in 563af8b
|
Normal 'make' or 'make all' does not require downloading prebuilt ELF executables from the rv32emu-prebuilt repo. However, 'deps_emcc' always depends on the 'artifact' target, even when not using emcc, causing 'make' or 'make all' to always download prebuilt ELF executables. To prevent this, the 'artifact' target is moved under the emcc build condition. Related: sysprog21#491
Now, we fetch the SHA1 first and verify the binaries. Only if the check fails, the download begins. Close sysprog21#491
We fetch the SHA1 first and verify the binaries. If any verification fails, the returned value of the "verify" macro becomes non-zero. Only if the verification fails, the download begins. Close sysprog21#491
Normal 'make' or 'make all' does not require downloading prebuilt ELF executables from the rv32emu-prebuilt repo. However, 'deps_emcc' always depends on the 'artifact' target, even when not using emcc, causing 'make' or 'make all' to always download prebuilt ELF executables. To prevent this, the 'artifact' target is moved under the emcc build condition. Related: sysprog21#491
We fetch the SHA1 first and verify the binaries. If any verification fails, the returned value of the "verify" macro becomes non-zero. Only if the verification fails, the download begins. Close sysprog21#491
After the successful integration of #474, our GitHub CI/CD pipeline now automatically publishes a tarball of the latest RISC-V executables, keeping the rv32emu source tree clean. However, we have noticed that the tarball is being downloaded multiple times during tests, leading to unnecessary delays. To improve this, we can cache the downloaded files beforehand and simply verify the extracted RISC-V executables during the testing phase.
The text was updated successfully, but these errors were encountered: