-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Version 3.13.5 seems to break when using config file #369
Comments
Note that this is running in an Alpine Docker container. /data $ markdown-link-check --version
3.13.5
/data $ cat /etc/os-release
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.19.4
PRETTY_NAME="Alpine Linux v3.19"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
/data $ npm --version
10.9.0
/data $ node --version
v20.18.0 |
#### Description the changelog workflow has started failing, likely due to regressions in the tool's latest release. Pinning until fixed #### Link to tracking issue probably related to - tcort/markdown-link-check#369 - tcort/markdown-link-check#370
I have observed the same issue for https://github.com/eclipse-kuksa/kuksa-databroker project With config, "silent" failure for 3.13.5, "success" for 3.12.2
Without config fail, success
Config file for reference
|
With
I just get shown the filenames, with no checking
If I remove the config file The config file is the following and it seems these exceptions aren't needed anymore: {
"httpHeaders": [
{
"urls": [
"https://github.com/",
"https://guides.github.com/",
"https://docs.github.com/",
"https://help.github.com/",
"https://support.github.com"
],
"headers": {
"Accept-Encoding": "zstd, br, gzip, deflate"
}
}
]
} |
Facing same issue here in OpenTelemetry Python https://github.com/open-telemetry/opentelemetry-python/actions/runs/11709458753/job/32613721323?pr=4251 |
#### Description the changelog workflow has started failing, likely due to regressions in the tool's latest release. Pinning until fixed #### Link to tracking issue probably related to - tcort/markdown-link-check#369 - tcort/markdown-link-check#370
to me the issue is here markdown-link-check/markdown-link-check Line 291 in d090c91
if no reporters parameter is set at command line, it's the default reporter that will be used markdown-link-check/markdown-link-check Line 216 in d090c91
|
I have the same problem with MegaLinter :( [markdown-link-check] command: ['markdown-link-check', '--quiet', '-c', '/action/lib/.automation/.markdown-link-check.json', 'markdown_good_1.md', 'markdown_good_2.md']
[markdown-link-check] CWD: /tmp/lint/.automation/test/markdown
[markdown-link-check] result: 1 https://github.com/oxsecurity/megalinter/actions/runs/11750534244/job/32738969615?pr=4228 |
This is pinned because of tcort/markdown-link-check#369 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This is pinned because of tcort/markdown-link-check#369 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
same here, working perfectly on Mac OS X, but on CI/CD using Node20 in Ubuntu latest in a GH Workflow is failing |
This addresses [Issue#369], where using a config file that doesn't specify a reporter breaks. We update the code so that when there's a config without a reporter, we fallback to the default one. [issue#369]: tcort#369
#### Description the changelog workflow has started failing, likely due to regressions in the tool's latest release. Pinning until fixed #### Link to tracking issue probably related to - tcort/markdown-link-check#369 - tcort/markdown-link-check#370
This is pinned because of tcort/markdown-link-check#369 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Replace markdown-link-check with lychee to reduce maintenance burden, as the current version has been broken for 2 months [1]. [1] tcort/markdown-link-check#369 Signed-off-by: Michael Adler <michael.adler@siemens.com>
Replace markdown-link-check with lychee to reduce maintenance burden, as the current version has been broken for 2 months [1]. [1] tcort/markdown-link-check#369 Signed-off-by: Michael Adler <michael.adler@siemens.com>
With version 3.13.5, I am unable to get the utility to properly check links.
markdown-link-check-config.json
:README2.md
:Example run:
This seems to be a regression from 3.12.x
The text was updated successfully, but these errors were encountered: