Do not override reporter option if not defined in config file (issue #369) #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
approved these changes
Nov 7, 2024
|
Do I need to do something to start the test library workflow ? |
It needs a maintainer to approve. I'm in the same situation with pending PRs and I haven't committed to this repo before. |
|
@tcort any chance you could merge this? This is breaking builds downstream and I have confirmed that this fix works for us. I believe this issue is breaking all cases of using a config file as far as I can tell and there are no current ways to work around this issue for users. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 just did it |
|
@tcort would it be possible to review changes and valide them if it's OK for you ? |
bobrik
added a commit
to bobrik/ebpf_exporter
that referenced
this pull request
Jan 17, 2025
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #369