Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Defining Requests article code example uses incorrect 'QueryParameters' #22

Closed
tdeleon opened this issue Nov 29, 2023 · 0 comments
Closed

Defining Requests article code example uses incorrect 'QueryParameters' #22

tdeleon opened this issue Nov 29, 2023 · 0 comments
Assignees
@tdeleon
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
2.1.1

Comments

@tdeleon
Copy link
Owner

tdeleon commented Nov 29, 2023 •
edited
Loading

The example uses QueryParameters, but should use QueryItems.
@tdeleon tdeleon added bug Something isn't working documentation Improvements or additions to documentation labels Nov 29, 2023
@tdeleon tdeleon self-assigned this Nov 29, 2023
tdeleon added a commit that referenced this issue Dec 2, 2023
@tdeleon
#22: Change incorrect reference of 'QueryParameters' to 'QueryItems' …
1058bda 
…in documentation
@tdeleon tdeleon closed this as completed Dec 2, 2023
@tdeleon tdeleon mentioned this issue Dec 2, 2023
Merged
@tdeleon tdeleon added this to the 2.1.1 milestone Dec 2, 2023
tdeleon added a commit that referenced this issue Dec 2, 2023
@tdeleon
Release 2.1.1 (#24)
c4d2a8f 
* Completed redesign (#9)

* Complete rewrite
* Migrate documentation to DocC

* Doc organization

* Update test.yml

* Readme/doc landing page

* Add CustomStringConvertible support for PathComponents.Builder

* Move parseHTTPStatusErrors to Configuration

* Update docs

* Add configuration option to append trailing slash

* Fix issue inheriting configuration

* Remove URLSession on Service protocol

* Re-organize docs; update docs for parseHTTPStatusErrors & appendTrailingSlashToPath

* Update tests for new configuration options

* Update documentation

* Add missing Header init documentation;  add build expression for optionals on Headers, PathParameters, QueryItems

* #13 - Add support for dictionaries to Body

* #14 - Improve documentation examples

* #14 - Improve documentation examples

* #14 - Improve documentation examples

* #15 - Build block method of RequestBuilder was not marked as public

* Update documentation link to next version (2.1.0)

* Change to version independent hosted documentation link.

* Fix typo in Body.Builder doc example

* #17: fix table of default values for Request.Configuration.default

* Add tests for task cancellation; add option for delayed response in URLProtocolMock

* #18 Request.Properties properties should be public

* 19: Add URLMock library for mocking test tools (#23)

* #19: Add URLMock module

* #19: Adding documentation for URLMock

* #19: Move MockResponse out of URLMock extension; add additional method for creating URLSession with MockResponse closure

* #19: Restructuring, updating docs

* #19: Adjust URLMock.session() method signature

* #19: Restructuring

* #19: Change parameter name to avoid incorrect autocompletion

* #19: Update parameter name

* #19: Finalizing documentation

* Finalizing docs (also in main target)

* #19: Add missing FoundationNetworking imports

* #19: Implement delay using Thread.sleep for win/linux compatibility

* #19: Implement Thread.sleep() for win/linux compatibility

* #19: Disable delayed cancellation test on Windows/Linux

* #21: Remove force unwrap for decoding errors

* #22: Change incorrect reference of 'QueryParameters' to 'QueryItems' in documentation

* #19: Add URLMock to swift package index doc build targets
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tdeleon tdeleon

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
1 participant
@tdeleon