Add inherited JSONDecoder property on APIComponent #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeleon
added
documentation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
decoderstatic property toAPIComponent. The property should be propagated down through Requests, allowing overrides at each level. Currently, customized decoders must be specified each time a request is sent (in thesend()methods). Often times an API will need to use the same decoder for multiple Requests, and it is tedious to pass this in on each request.The Request
send()methods will allow overriding through the existing method signatures. This will also ensure source compatibility is maintained, along with existing default behavior (when no decoder is specified).If the values are not specified, there should be default protocol implementations of
JSONDecoder().