Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CHI-3069: HRM create lambda #2669

Merged
merged 10 commits into from
Jan 14, 2025
Merged

CHI-3069: HRM create lambda #2669

merged 10 commits into from
Jan 14, 2025

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Dec 27, 2024

Description

  • Add a RESERVATION_ACCEPTED handler to create a HRM contact
  • Largely C&P from serverless
  • Uses internal HRM endpoint so would be secure for production

Related PRs

https://github.com/techmatters/infrastructure-config/pull/408
techmatters/hrm#800
techmatters/serverless#740
#2662 (this PR is a follow up for this one, review it first)
#2674 (follow on from this one, review after)

TODO:

Refactor repo to reuse contact and form definition types between Flex and Lambdas - for another PR
Tests (coming in a follow up)

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags added
  • [N/A] Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

Copy link
Collaborator

@GPaoloni GPaoloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


export const eventTypes: EventType[] = [RESERVATION_ACCEPTED];

// Temporarily copied to this repo, will share the flex types when we move them into the same repo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹?

@stephenhand stephenhand merged commit 008fd8e into master Jan 14, 2025
10 checks passed
@stephenhand stephenhand deleted the CHI-3069-hrm_create_lambda branch January 14, 2025 16:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants