-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CHI-3068: Remove HRM contact creation #740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a question, and maybe you could link which PRs should be merged & deployed before this can be rolled out?
shell: bash | ||
|
||
|
||
- name: Add DELEGATE_WEBHOOK_URL | ||
run: echo "DELEGATE_WEBHOOK_URL=https://hrm-development.tl.techmatters.org/lambda/twilio/account-scoped" >> .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in the "general" env variables, as part of the main action? I'm asking cause I assume this URL will be required for every account, not just some of them (this file intended to be used in the later).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably will when we roll it out everywhere, I just wanted to be extra cautious about where we switch on the delegation code until we're sure it's working ok, since it might completely break our task router handling if it's broken
Description
Now HRM contacts are created from a lambda, remove them from here
Related PRs:
https://github.com/techmatters/infrastructure-config/pull/408
techmatters/hrm#800
techmatters/flex-plugins#2662
techmatters/flex-plugins#2669 (follow on from 2662, review after)
techmatters/flex-plugins#2674 (follow on from 2669, review after)
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P