Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CHI-3068: Remove HRM contact creation #740

Merged
merged 19 commits into from
Jan 13, 2025

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Dec 27, 2024

Description

Now HRM contacts are created from a lambda, remove them from here

Related PRs:

https://github.com/techmatters/infrastructure-config/pull/408
techmatters/hrm#800
techmatters/flex-plugins#2662
techmatters/flex-plugins#2669 (follow on from 2662, review after)
techmatters/flex-plugins#2674 (follow on from 2669, review after)

Checklist

  • Corresponding issue has been opened
  • [N/A] New tests added
  • [N/A] Feature flags / configuration added

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and the notification to be posted in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand marked this pull request as draft December 27, 2024 08:20
@stephenhand stephenhand requested a review from GPaoloni December 27, 2024 19:43
@stephenhand stephenhand marked this pull request as ready for review December 27, 2024 19:46
Copy link
Collaborator

@GPaoloni GPaoloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a question, and maybe you could link which PRs should be merged & deployed before this can be rolled out?

Comment on lines +233 to +237
shell: bash


- name: Add DELEGATE_WEBHOOK_URL
run: echo "DELEGATE_WEBHOOK_URL=https://hrm-development.tl.techmatters.org/lambda/twilio/account-scoped" >> .env
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the "general" env variables, as part of the main action? I'm asking cause I assume this URL will be required for every account, not just some of them (this file intended to be used in the later).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably will when we roll it out everywhere, I just wanted to be extra cautious about where we switch on the delegation code until we're sure it's working ok, since it might completely break our task router handling if it's broken

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants