Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CHI-3068: Remove HRM contact creation #740

Merged
merged 19 commits into from
Jan 13, 2025
Merged

CHI-3068: Remove HRM contact creation #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c61b2f5
Add env var injection to AS_DEV
stephenhand Dec 20, 2024
34851dc
Logging
stephenhand Dec 23, 2024
50ef56a
Logging
stephenhand Dec 23, 2024
5f352a3
Remove redundant flex flow SIDs from AS_DEV context to reduce context…
stephenhand Dec 23, 2024
cc2765b
Fix original webhook URL
stephenhand Dec 23, 2024
c236a15
Include body in delegated webhook call
stephenhand Dec 23, 2024
a105153
Go back to awaiting delegated call
stephenhand Dec 23, 2024
96268f6
Logging
stephenhand Dec 23, 2024
4791e2d
Logging
stephenhand Dec 23, 2024
1d920bf
Fixed promise await for forwarding delegate
stephenhand Dec 23, 2024
18d79b8
Logging
stephenhand Dec 23, 2024
913234e
Logging
stephenhand Dec 23, 2024
86438fe
Split event from request before forwarding
stephenhand Dec 23, 2024
7a51bbf
Test with empty body
stephenhand Dec 24, 2024
479327e
Add correct contect type
stephenhand Dec 24, 2024
7fc72e4
Log out headers
stephenhand Dec 24, 2024
96cf7ff
Filter forwarded headers
stephenhand Dec 24, 2024
49a95cf
disable HRM contact creation
stephenhand Dec 27, 2024
17a402a
remove HRM contact creation
stephenhand Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions .github/actions/custom-actions/aselo_development_custom/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ runs:
with:
ssm_parameter: "FACEBOOK_PAGE_ACCESS_TOKEN_105220114492262_Aselo-Development"
env_variable_name: "FACEBOOK_PAGE_ACCESS_TOKEN"
- name: Set helpline Instagram Flex Flow SID
uses: "marvinpinto/action-inject-ssm-secrets@latest"
with:
ssm_parameter: "DEV_TWILIO_AS_INSTAGRAM_FLEX_FLOW_SID"
env_variable_name: "INSTAGRAM_FLEX_FLOW_SID"
- name: Set helpline Instagram Studio Flow SID
uses: "marvinpinto/action-inject-ssm-secrets@latest"
with:
Expand All @@ -90,11 +85,6 @@ runs:
ssm_parameter: "/development/instagram/${{inputs.account-sid}}/messaging_mode"
env_variable_name: "INSTAGRAM_TWILIO_MESSAGING_MODE"
# Line environment variables
- name: Set helpline Line Flex Flow SID
uses: "marvinpinto/action-inject-ssm-secrets@latest"
with:
ssm_parameter: "DEV_TWILIO_AS_LINE_FLEX_FLOW_SID"
env_variable_name: "LINE_FLEX_FLOW_SID"
- name: Set Line Channel Secret
uses: "marvinpinto/action-inject-ssm-secrets@latest"
with:
Expand Down Expand Up @@ -126,11 +116,6 @@ runs:
with:
ssm_parameter: "/development/modica/${{inputs.account-sid}}/app_password"
env_variable_name: "MODICA_APP_PASSWORD"
- name: Set Modica Flex Flow Sid
uses: "marvinpinto/action-inject-ssm-secrets@latest"
with:
ssm_parameter: "/development/twilio/${{inputs.account-sid}}/modica_flex_flow_sid"
env_variable_name: "MODICA_FLEX_FLOW_SID"
- name: Set helpline Modica Studio Flow SID
uses: "marvinpinto/action-inject-ssm-secrets@latest"
with:
Expand Down Expand Up @@ -203,18 +188,12 @@ runs:
- name: Add FACEBOOK_PAGE_ACCESS_TOKEN
run: echo "FACEBOOK_PAGE_ACCESS_TOKEN=${{ env.FACEBOOK_PAGE_ACCESS_TOKEN }}" >> .env
shell: bash
- name: Add INSTAGRAM_FLEX_FLOW_SID
run: echo "INSTAGRAM_FLEX_FLOW_SID=${{ env.INSTAGRAM_FLEX_FLOW_SID }}" >> .env
shell: bash
- name: Add INSTAGRAM_STUDIO_FLOW_SID
run: echo "INSTAGRAM_STUDIO_FLOW_SID=${{ env.INSTAGRAM_STUDIO_FLOW_SID }}" >> .env
shell: bash
- name: Add INSTAGRAM_TWILIO_MESSAGING_MODE
run: echo "INSTAGRAM_TWILIO_MESSAGING_MODE=${{ env.INSTAGRAM_TWILIO_MESSAGING_MODE }}" >> .env
shell: bash
- name: Add LINE_FLEX_FLOW_SID
run: echo "LINE_FLEX_FLOW_SID=${{ env.LINE_FLEX_FLOW_SID }}" >> .env
shell: bash
- name: Add LINE_CHANNEL_SECRET
run: echo "LINE_CHANNEL_SECRET=${{ env.LINE_CHANNEL_SECRET }}" >> .env
shell: bash
Expand All @@ -233,9 +212,6 @@ runs:
- name: Add MODICA_APP_PASSWORD
run: echo "MODICA_APP_PASSWORD=${{ env.MODICA_APP_PASSWORD }}" >> .env
shell: bash
- name: Add MODICA_FLEX_FLOW_SID
run: echo "MODICA_FLEX_FLOW_SID=${{ env.MODICA_FLEX_FLOW_SID }}" >> .env
shell: bash
- name: Add MODICA_STUDIO_FLOW_SID
run: echo "MODICA_STUDIO_FLOW_SID=${{ env.MODICA_STUDIO_FLOW_SID }}" >> .env
shell: bash
Expand All @@ -254,4 +230,9 @@ runs:

- name: Add MODICA_TEST_SEND_MESSAGE_URL
run: echo "MODICA_TEST_SEND_MESSAGE_URL=${{ env.MODICA_TEST_SEND_MESSAGE_URL }}" >> .env
shell: bash


- name: Add DELEGATE_WEBHOOK_URL
run: echo "DELEGATE_WEBHOOK_URL=https://hrm-development.tl.techmatters.org/lambda/twilio/account-scoped" >> .env
Comment on lines +233 to +237
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the "general" env variables, as part of the main action? I'm asking cause I assume this URL will be required for every account, not just some of them (this file intended to be used in the later).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably will when we roll it out everywhere, I just wanted to be extra cautious about where we switch on the delegation code until we're sure it's working ok, since it might completely break our task router handling if it's broken

shell: bash
Loading
Loading