Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adds Webhook for Tekton Operator CRs #330

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Adds Webhook for Tekton Operator CRs #330

merged 4 commits into from
Jun 29, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Jun 16, 2021 •
edited
Loading

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 16, 2021
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 16, 2021
Renames webhook to proxy-webhook
5606c2e 
This renames the existing webhook to proxy webhook so that we can ]
have a webhook for Operator CRs.

Signed-off-by: Shivam Mukhade smukhade@redhat.com
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 17, 2021
Adds webhook for Tekton Operator CRs
c6cca1c 
This add a webhook to validate and set defaults for Tekton Operator CRs.
In this it enables it for TektonConfig CR.
Also, add the webhook deployment yaml with supporting resources.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonconfig_types.go 0.0% 50.0% 50.0
pkg/apis/operator/v1alpha1/tektonconfig_validation.go Do not exist 91.7%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonconfig_types.go 0.0% 50.0% 50.0
pkg/apis/operator/v1alpha1/tektonconfig_validation.go Do not exist 91.7%
pkg/apis/operator/v1alpha1/tektondashboard_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektontrigger_validation.go Do not exist 100.0%

Enables webhook for Pipeline, Triggers & Dashboard Component
30cb68e 
This enables the webhook to validate and set defaults for pipeline,
triggers and dashboard component.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 changed the title [WIP] Adding Webhook Adds Webhook for Tekton Operator CRs Jun 18, 2021
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/common.go 0.0% 80.0% 80.0
pkg/apis/operator/v1alpha1/tektonaddon_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonaddon_validation.go Do not exist 95.0%
pkg/apis/operator/v1alpha1/tektonconfig_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonconfig_types.go 0.0% 50.0% 50.0
pkg/apis/operator/v1alpha1/tektonconfig_validation.go Do not exist 88.9%
pkg/apis/operator/v1alpha1/tektondashboard_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektontrigger_validation.go Do not exist 100.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/common.go 0.0% 80.0% 80.0
pkg/apis/operator/v1alpha1/tektonaddon_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonaddon_validation.go Do not exist 95.0%
pkg/apis/operator/v1alpha1/tektonconfig_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonconfig_types.go 0.0% 50.0% 50.0
pkg/apis/operator/v1alpha1/tektonconfig_validation.go Do not exist 88.9%
pkg/apis/operator/v1alpha1/tektondashboard_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektontrigger_validation.go Do not exist 100.0%

Enablen webhook for TektonAddon and adds webhook for OpenShift
8ff1269 
This enables webhook for addon for openshift and adds deployment
and supporting resources for openshift platform.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/common.go 0.0% 80.0% 80.0
pkg/apis/operator/v1alpha1/tektonaddon_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonaddon_validation.go Do not exist 95.0%
pkg/apis/operator/v1alpha1/tektonconfig_defaults.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonconfig_types.go 0.0% 50.0% 50.0
pkg/apis/operator/v1alpha1/tektonconfig_validation.go Do not exist 88.9%
pkg/apis/operator/v1alpha1/tektondashboard_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go Do not exist 100.0%
pkg/apis/operator/v1alpha1/tektontrigger_validation.go Do not exist 100.0%

@sm43 sm43 mentioned this pull request Jun 21, 2021
Merged
3 tasks
@nikhil-thomas
Copy link
Member

/lgtm
🔥

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@nikhil-thomas
Copy link
Member

/meow

@tekton-robot
Copy link
Contributor

@nikhil-thomas: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhil-thomas
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@tekton-robot tekton-robot merged commit 450ac15 into tektoncd:main Jun 29, 2021
dibyom added a commit that referenced this pull request Jul 1, 2021
@dibyom
Add proxy-webhook to the list of built images
ab68fe4 
Nightly pipeline was failing since a new proxy-webhook binary was added (#330)
Fixes #344
@dibyom dibyom mentioned this pull request Jul 1, 2021
Merged
3 tasks
tekton-robot pushed a commit that referenced this pull request Jul 2, 2021
@dibyom @tekton-robot
Add proxy-webhook to the list of built images
f58e4b6 
Nightly pipeline was failing since a new proxy-webhook binary was added (#330)
Fixes #344
@sm43 sm43 deleted the webhook branch July 7, 2021 09:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@nikhil-thomas nikhil-thomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sm43 @tekton-robot @nikhil-thomas