Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add proxy-webhook to the list of built images #345

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Add proxy-webhook to the list of built images #345

merged 1 commit into from
Jul 2, 2021

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jul 1, 2021

Changes

Nightly pipeline was failing since a new proxy-webhook binary was added (#330)
Fixes #344

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@dibyom
Add proxy-webhook to the list of built images
ab68fe4 
Nightly pipeline was failing since a new proxy-webhook binary was added (#330)
Fixes #344
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 1, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2021
@dibyom
Copy link
Member Author

dibyom commented Jul 1, 2021

/cc @sm43 @nikhil-thomas not 100% sure if this is correct...but I think this should fix the failing nightly

@nikhil-thomas
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
vdemeester
vdemeester approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
pradeepitm12
pradeepitm12 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nikhil-thomas,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit f58e4b6 into main Jul 2, 2021
@sm43 sm43 deleted the dibyom-patch-1 branch July 14, 2022 03:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@vdemeester vdemeester

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator Nightly failing
5 participants
@dibyom @nikhil-thomas @tekton-robot @vdemeester @pradeepitm12