Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

E2E tests broken #1475

Closed
dibyom opened this issue Nov 2, 2022 · 2 comments
Closed

E2E tests broken #1475

dibyom opened this issue Nov 2, 2022 · 2 comments
Assignees
@dibyom
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
Triggers v0.22.0

Comments

@dibyom
Copy link
Member

dibyom commented Nov 2, 2022 •
edited
Loading

Expected Behavior

E2E tests run successfully

Actual Behavior

With Pipeline v0.41 release, the min version of k8s needed is 1.23. Triggers e2e tests first install the latest version of Pipelines. Currently they run on GKE clusters provisioned using Boskos. By default, the use the gke stable channel where the default release is 1.22. This means all of our e2e tests are now failing while trying to install pipelines.

See
 as an example.
Logs: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_triggers/1469/pull-tekton-triggers-integration-tests/1587533862802558976
@dibyom dibyom added the kind/bug Categorizes issue or PR as related to a bug. label Nov 2, 2022
@dibyom
Copy link
Member Author

dibyom commented Nov 2, 2022

I think it makes sense to update our tests to run on kind instead of switching the GKE channel to rapid or use the latest release from the stable channel both of which would result in using k8s >1.23

dibyom added a commit to dibyom/triggers that referenced this issue Nov 2, 2022
@dibyom
Modify e2e test scripts to support running on kind
9670455 
In our Prow based CI environment, the e2e tests currently run on GKE clusters
provisioned using Boskos. This change enables them to run against a kind
cluster following the steps outlined in
https://github.com/tektoncd/plumbing/blob/main/docs/kind-e2e.md

Part of tektoncd#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Nov 2, 2022
Merged
4 tasks
dibyom added a commit to dibyom/plumbing that referenced this issue Nov 2, 2022
@dibyom
Migrate Triggers e2e test to kind
2ba9904 
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests:

1. Use latest builder image for the time being
2. Adds a `pipeline-kind-e2e: "true"` label that is used for podAntiAffinity -
we don't want multiple kind jobs running on the same nodes.

Part of tektoncd/triggers#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Nov 2, 2022
Merged
2 tasks
@dibyom
Copy link
Member Author

dibyom commented Nov 2, 2022

Looks like stable channels for gke is now using 1.23:

ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.23. This is to prepare for the removal of Dockershim in Kubernetes v1.24. We recommend that you migrate to image types based on Containerd (examples). For more information, contact Cloud Support.

https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_triggers/1476/pull-tekton-triggers-integration-tests/1587874585666129920

So, a quicker fix would be to update our plumbing to include tektoncd/plumbing#1251

dibyom added a commit to dibyom/triggers that referenced this issue Nov 2, 2022
@dibyom
Use cos_containerd gke image for e2e tests
ade0f87 
This commit updates our plumbing dependency to pull in tektoncd/plumbing#1251
which updates the GKE image to cos_containerd. The older cos image is no longer
supported as of GKE v1.23.

Part of tektoncd#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Nov 2, 2022
Merged
4 tasks
dibyom added a commit to dibyom/triggers that referenced this issue Nov 2, 2022
@dibyom
Use cos_containerd gke image for e2e tests
f2e5f0e 
This commit updates our plumbing dependency to pull in tektoncd/plumbing#1251
which updates the GKE image to cos_containerd. The older cos image is no longer
supported as of GKE v1.23.

Part of tektoncd#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Nov 3, 2022
@dibyom
Replace PodSecurityPolicy with PodSecurityAdmission
c0f697d 
This commit drops the Triggers PodSecurityPolicy since its deprecated and is
going to be removed in Kubernetes 1.25 in favor of PodSecurityAdmission.

In addition, it adds the `securityContext` required for the "restricted"
PodSecurityAdmission levels. These changes are necessary for Triggers to work
with Pipelines v0.41 and higher because tektoncd/pipeline#5652  started
enforcing the restricted pod security level for all pods in the
`tekton-pipelines` namespace (which includes the triggers controller, webhook,
and core interceptor deployments).

Fixes tektoncd#1447 and required for tektoncd#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@savitaashture savitaashture added this to the Triggers v0.22.0 milestone Nov 3, 2022
dibyom added a commit to dibyom/triggers that referenced this issue Nov 3, 2022
@dibyom
Replace PodSecurityPolicy with PodSecurityAdmission
28bfb0f 
This commit drops the Triggers PodSecurityPolicy since its deprecated and is
going to be removed in Kubernetes 1.25 in favor of PodSecurityAdmission.

In addition, it adds the `securityContext` required for the "restricted"
PodSecurityAdmission levels. These changes are necessary for Triggers to work
with Pipelines v0.41 and higher because tektoncd/pipeline#5652  started
enforcing the restricted pod security level for all pods in the
`tekton-pipelines` namespace (which includes the triggers controller, webhook,
and core interceptor deployments).

Fixes tektoncd#1447 and required for tektoncd#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue Nov 4, 2022
@dibyom @tekton-robot
Use cos_containerd gke image for e2e tests
c0a2ffe 
This commit updates our plumbing dependency to pull in tektoncd/plumbing#1251
which updates the GKE image to cos_containerd. The older cos image is no longer
supported as of GKE v1.23.

Part of #1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue Nov 4, 2022
@dibyom @tekton-robot
Replace PodSecurityPolicy with PodSecurityAdmission
ce7b976 
This commit drops the Triggers PodSecurityPolicy since its deprecated and is
going to be removed in Kubernetes 1.25 in favor of PodSecurityAdmission.

In addition, it adds the `securityContext` required for the "restricted"
PodSecurityAdmission levels. These changes are necessary for Triggers to work
with Pipelines v0.41 and higher because tektoncd/pipeline#5652  started
enforcing the restricted pod security level for all pods in the
`tekton-pipelines` namespace (which includes the triggers controller, webhook,
and core interceptor deployments).

Fixes #1447 and required for #1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue Nov 7, 2022
@dibyom @tekton-robot
Modify e2e test scripts to support running on kind
ea35ac4 
In our Prow based CI environment, the e2e tests currently run on GKE clusters
provisioned using Boskos. This change enables them to run against a kind
cluster following the steps outlined in
https://github.com/tektoncd/plumbing/blob/main/docs/kind-e2e.md

Part of #1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom closed this as completed Nov 8, 2022
Repository owner moved this from Todo to Done in Tekton Community Roadmap Nov 8, 2022
dibyom added a commit to dibyom/plumbing that referenced this issue Nov 30, 2022
@dibyom
Migrate Triggers e2e test to kind
c2adf0d 
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests:

1. Use latest builder image for the time being
2. Adds a `pipeline-kind-e2e: "true"` label that is used for podAntiAffinity -
we don't want multiple kind jobs running on the same nodes.

Part of tektoncd/triggers#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/plumbing that referenced this issue Nov 30, 2022
@dibyom
Migrate Triggers e2e test to kind
9dc3786 
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests:

1. Use latest builder image for the time being
2. Adds a `pipeline-kind-e2e: "true"` label that is used for podAntiAffinity -
we don't want multiple kind jobs running on the same nodes.

Part of tektoncd/triggers#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/plumbing that referenced this issue Jan 20, 2023
@dibyom
Migrate Triggers e2e test to kind
3d85429 
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests:

1. Use latest builder image for the time being
2. Adds a `pipeline-kind-e2e: "true"` label that is used for podAntiAffinity -
we don't want multiple kind jobs running on the same nodes.

Part of tektoncd/triggers#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit to tektoncd/plumbing that referenced this issue Jan 26, 2023
@dibyom @tekton-robot
Migrate Triggers e2e test to kind
8910670 
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests:

1. Use latest builder image for the time being
2. Adds a `pipeline-kind-e2e: "true"` label that is used for podAntiAffinity -
we don't want multiple kind jobs running on the same nodes.

Part of tektoncd/triggers#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dibyom dibyom

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Tekton Community Roadmap
Status: Done
Milestone
Triggers v0.22.0
Development

No branches or pull requests
2 participants
@dibyom @savitaashture