Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modify e2e test scripts to support running on kind #1476

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Nov 2, 2022

Changes

In our Prow based CI environment, the e2e tests currently run on GKE clusters provisioned using Boskos. This change enables them to run against a kind cluster following the steps outlined in
https://github.com/tektoncd/plumbing/blob/main/docs/kind-e2e.md

Part of #1475

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

In our Prow based CI environment, the e2e tests currently run on GKE clusters
provisioned using Boskos. This change enables them to run against a kind
cluster following the steps outlined in
https://github.com/tektoncd/plumbing/blob/main/docs/kind-e2e.md

Part of tektoncd#1475

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 2, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2022
@abayer
Copy link
Contributor

abayer commented Nov 3, 2022

/lgtm

Woo!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@dibyom
Copy link
Member Author

dibyom commented Nov 3, 2022

/hold

(we should merge #1477 first)

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@savitaashture
Copy link
Contributor

/retest

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@dibyom
Copy link
Member Author

dibyom commented Nov 7, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@tekton-robot tekton-robot merged commit ea35ac4 into tektoncd:main Nov 7, 2022
@dibyom dibyom added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants