-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(ontology-find-icon-helper): add package #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to draft - as I've just realised the code (useOntologyStyles) that this helper deprecates - actually has more opinion that needs to be ported over. Plus, I might need to do some small changes for reactivity (which we were originally trying to avoid) |
- Previously used by useOntologyStyles - Copied into ontology-find-icon-helper to achieve parity - Very likely this logic will be changed or removed at a later date
davec504
approved these changes
Dec 2, 2024
davec504
approved these changes
Dec 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful: Diff of changes MINUS initial package config files
Ticket: https://telicent.atlassian.net/browse/TELFE-772
Goal
Testing Method
Engineering notes
Adding to app
41e34a6
How icons are loaded via direct use of ontologyFindIconHelper:
6cf9cef
11070a0
How icons are loaded via re-usable component:
31ac680
Out-of-scope
Related PRs:
🕵️ Review Guidance
General guidance
For PR REVIEWER:
[pr-owner-resolve]
: Jim is also editing this file"pr-author-resolve
PR author can resolve after readingpr-author-delete
(rare) delete after reading to avoid confusionFor PR AUTHOR: