-
Notifications
You must be signed in to change notification settings - Fork 158
Local Activities fail and don't retry after reaching LocalRetryThreshold #1261
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Closed
Tracked by
#1361
Milestone
Comments
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Nov 27, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Nov 28, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Nov 29, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Nov 30, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Nov 30, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Nov 30, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 1, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 1, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 1, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 1, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 1, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 1, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 2, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 2, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 3, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 5, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 5, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
to Spikhalskiy/java-sdk
that referenced
this issue
Dec 6, 2022
Spikhalskiy
added a commit
that referenced
this issue
Dec 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Expected Behavior
Local Activity should schedule a timer on the server when it reaches LocalActivityThreshold according to its backoff strategy.
Actual Behavior
Instead, if Local Activity fails after LocalActivityThreshold is reached, the fail propagates to the workflow
Steps to Reproduce the Problem
Unit test Spikhalskiy@ea6252a#diff-b74049b45234315b43ae6729f80ee4c54cca4cbb081f97ef9ab42cc77e9e3264R39 is expected to pass, but instead, it fails.
Additional context
It looks like the code that was scheduling the timer was removed by mistake in the PR from the earliest days of Temporal that was reimplementing errors handling, specifically here: https://github.com/temporalio/sdk-java/pull/101/files#diff-f6a342e5baa618f03fdb6a83c6e070e5b57b9a9d9f3e1460b928149faa12b57cR237
It wasn't caught because the unit test testing La backoff that falls back to the server timers is not tested by the existing tests.
The text was updated successfully, but these errors were encountered: