Simplify code and error handling between ActivityWorker and LocalActivityWorker #1263
Conversation
Spikhalskiy
force-pushed
the
activity-worker-refactoring
branch
4 times, most recently
from
9a896ee to
815c464
Compare
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
activity-worker-refactoring
branch
from
815c464 to
e5582db
Compare
| // TODO should go away with SimulatedTimeoutFailure | ||
| if (exception instanceof TimeoutFailure) { | ||
| exception = new SimulatedTimeoutFailure((TimeoutFailure) exception); |
There was a problem hiding this comment.
Todo refers to thing that it implies doesn't exist, but seems to
There was a problem hiding this comment.
It will go away in the next PR, didn't want to throw everything into one.
| // For small backoff we do local retry. Otherwise we will schedule timer on server side. | ||
| // TODO(maxim): Use timer queue for retries to avoid tying up a thread. |
There was a problem hiding this comment.
Did you find where this implementation actually is, if anywhere?
There was a problem hiding this comment.
It was actually in the code base but was removed during fat finger refactoring more than 2 years ago. #1261
Will need to bring it back in a backward-compatible manner.
Spikhalskiy
force-pushed
the
activity-worker-refactoring
branch
2 times, most recently
from
3483b7c to
f026ba1
Compare
|
To save me a bit of time, can you clarify which parts are code moves and which parts are new code I should focus on? |
|
@cretz It's all code restructuring, deduplication by introducing parent classes, unification of implementation between workers, and ensuring that callback is always called for LAs. There is pretty much no new code. |
Spikhalskiy
force-pushed
the
activity-worker-refactoring
branch
from
f026ba1 to
f28cbc6
Compare
…vityWorker Make LocalActivityWorker more robust to unexpected errors Issue temporalio#1262
Spikhalskiy
force-pushed
the
activity-worker-refactoring
branch
from
f28cbc6 to
0fd824f
Compare
Simplify code and error handling between ActivityWorker and LocalActivityWorker
Make LocalActivityWorker more robust to unexpected errors
Partially addresses #1262