track_total_hits is disabled for Elasticsearch Scroll API #6566
Assignees
Labels
Comments
rodrigozhou
added a commit
that referenced
this issue
Oct 2, 2024
## What changed? <!-- Describe what has changed in this PR --> Remove track_total_hits from Scroll API ## Why? <!-- Tell your future self why have you made these changes --> `track_total_hits` cannot be disable in Scroll API. Issue: #6566 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
|
The issue is fixed in #6592, and it should be included in the next patch release. |
dnr
pushed a commit
that referenced
this issue
Oct 4, 2024
## What changed? <!-- Describe what has changed in this PR --> Remove track_total_hits from Scroll API ## Why? <!-- Tell your future self why have you made these changes --> `track_total_hits` cannot be disable in Scroll API. Issue: #6566 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
dnr
pushed a commit
that referenced
this issue
Oct 11, 2024
## What changed? <!-- Describe what has changed in this PR --> Remove track_total_hits from Scroll API ## Why? <!-- Tell your future self why have you made these changes --> `track_total_hits` cannot be disable in Scroll API. Issue: #6566 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Expected Behavior
Being allowed to batch reset workflows using a query string.
Actual Behavior
Given a query that returns workflows:
when I try to batch reset those workflows, I get the error:
omitting the
--dry_runmakes no difference.I understand that the setting cannot be disabled for the Elasticsearch Scroll API, and I think this is the exact problematic line: 3649fcf#diff-d50f473f260834fc429ccfa7f37b189b51b94bd82de0c1b75c7db2233e940f66R196
Steps to Reproduce the Problem
I'm fairly sure this broke for everyone starting with v1.24.0.
Specifications
The text was updated successfully, but these errors were encountered: