Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove track_total_hits from Scroll API #6592

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented Oct 2, 2024

What changed?

Remove track_total_hits from Scroll API

Why?

track_total_hits cannot be disable in Scroll API.

Issue: #6566

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

@rodrigozhou rodrigozhou requested a review from a team as a code owner October 2, 2024 23:19
@rodrigozhou rodrigozhou enabled auto-merge (squash) October 2, 2024 23:26
@rodrigozhou rodrigozhou merged commit fd5d265 into main Oct 2, 2024
46 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/fix-es-scan branch October 2, 2024 23:49
dnr pushed a commit that referenced this pull request Oct 4, 2024
## What changed?
<!-- Describe what has changed in this PR -->
Remove track_total_hits from Scroll API

## Why?
<!-- Tell your future self why have you made these changes -->
`track_total_hits` cannot be disable in Scroll API.

Issue: #6566

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
dnr pushed a commit that referenced this pull request Oct 11, 2024
## What changed?
<!-- Describe what has changed in this PR -->
Remove track_total_hits from Scroll API

## Why?
<!-- Tell your future self why have you made these changes -->
`track_total_hits` cannot be disable in Scroll API.

Issue: #6566

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants