Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Persistence context part 6: visibility store interfaces #2674

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Persistence context part 6: visibility store interfaces #2674

merged 1 commit into from
Mar 29, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 29, 2022

What changed?

  • Add context parameter to visibility store interfaces.
  • NOTE: there's no behavior change in this PR. SQL, Cassandra and ElasticSearch store implementation still ignores the context passed it. Those will be changed in a follow up PR.

Why?

  • Enforce persistence timeout, instead of always timeout after 10s
  • Required for host level task worker pool

How did you test it?

  • Existing test

Potential risks

  • Very low, context is currently ignored by persistence store implementation

Is hotfix candidate?

  • No.

@yycptt yycptt requested a review from yiminc March 29, 2022 22:50
@yycptt yycptt requested a review from a team as a code owner March 29, 2022 22:50
@yycptt yycptt merged commit 3af96c6 into temporalio:master Mar 29, 2022
@yycptt yycptt deleted the persistence-ctx-visibility-store branch March 29, 2022 23:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc