Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Persistence context part 6: visibility store interfaces #2674

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Persistence context part 6: visibility store interfaces #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 56 additions & 14 deletions common/persistence/visibility/store/elasticsearch/visibility_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ func (s *visibilityStore) GetName() string {
return persistenceName
}

func (s *visibilityStore) RecordWorkflowExecutionStarted(request *store.InternalRecordWorkflowExecutionStartedRequest) error {
func (s *visibilityStore) RecordWorkflowExecutionStarted(
_ context.Context,
request *store.InternalRecordWorkflowExecutionStartedRequest,
) error {
visibilityTaskKey := getVisibilityTaskKey(request.ShardID, request.TaskID)
doc, err := s.generateESDoc(request.InternalVisibilityRequestBase, visibilityTaskKey)
if err != nil {
Expand All @@ -144,7 +147,10 @@ func (s *visibilityStore) RecordWorkflowExecutionStarted(request *store.Internal
return s.addBulkIndexRequestAndWait(request.InternalVisibilityRequestBase, doc, visibilityTaskKey)
}

func (s *visibilityStore) RecordWorkflowExecutionClosed(request *store.InternalRecordWorkflowExecutionClosedRequest) error {
func (s *visibilityStore) RecordWorkflowExecutionClosed(
_ context.Context,
request *store.InternalRecordWorkflowExecutionClosedRequest,
) error {
visibilityTaskKey := getVisibilityTaskKey(request.ShardID, request.TaskID)
doc, err := s.generateESDoc(request.InternalVisibilityRequestBase, visibilityTaskKey)
if err != nil {
Expand All @@ -159,7 +165,10 @@ func (s *visibilityStore) RecordWorkflowExecutionClosed(request *store.InternalR
return s.addBulkIndexRequestAndWait(request.InternalVisibilityRequestBase, doc, visibilityTaskKey)
}

func (s *visibilityStore) UpsertWorkflowExecution(request *store.InternalUpsertWorkflowExecutionRequest) error {
func (s *visibilityStore) UpsertWorkflowExecution(
_ context.Context,
request *store.InternalUpsertWorkflowExecutionRequest,
) error {
visibilityTaskKey := getVisibilityTaskKey(request.ShardID, request.TaskID)
doc, err := s.generateESDoc(request.InternalVisibilityRequestBase, visibilityTaskKey)
if err != nil {
Expand All @@ -169,7 +178,10 @@ func (s *visibilityStore) UpsertWorkflowExecution(request *store.InternalUpsertW
return s.addBulkIndexRequestAndWait(request.InternalVisibilityRequestBase, doc, visibilityTaskKey)
}

func (s *visibilityStore) DeleteWorkflowExecution(request *manager.VisibilityDeleteWorkflowExecutionRequest) error {
func (s *visibilityStore) DeleteWorkflowExecution(
_ context.Context,
request *manager.VisibilityDeleteWorkflowExecutionRequest,
) error {
docID := getDocID(request.WorkflowID, request.RunID)

bulkDeleteRequest := &client.BulkableRequest{
Expand Down Expand Up @@ -253,7 +265,10 @@ func (s *visibilityStore) checkProcessor() {
}
}

func (s *visibilityStore) ListOpenWorkflowExecutions(request *manager.ListWorkflowExecutionsRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListOpenWorkflowExecutions(
_ context.Context,
request *manager.ListWorkflowExecutionsRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
Filter(elastic.NewTermQuery(searchattribute.ExecutionStatus, enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING.String()))
Expand All @@ -277,7 +292,10 @@ func (s *visibilityStore) ListOpenWorkflowExecutions(request *manager.ListWorkfl
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListClosedWorkflowExecutions(request *manager.ListWorkflowExecutionsRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListClosedWorkflowExecutions(
_ context.Context,
request *manager.ListWorkflowExecutionsRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
MustNot(elastic.NewTermQuery(searchattribute.ExecutionStatus, enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING.String()))
Expand All @@ -301,7 +319,10 @@ func (s *visibilityStore) ListClosedWorkflowExecutions(request *manager.ListWork
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListOpenWorkflowExecutionsByType(request *manager.ListWorkflowExecutionsByTypeRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListOpenWorkflowExecutionsByType(
_ context.Context,
request *manager.ListWorkflowExecutionsByTypeRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
Filter(
Expand All @@ -327,7 +348,10 @@ func (s *visibilityStore) ListOpenWorkflowExecutionsByType(request *manager.List
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListClosedWorkflowExecutionsByType(request *manager.ListWorkflowExecutionsByTypeRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListClosedWorkflowExecutionsByType(
_ context.Context,
request *manager.ListWorkflowExecutionsByTypeRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
Filter(elastic.NewTermQuery(searchattribute.WorkflowType, request.WorkflowTypeName)).
Expand All @@ -352,7 +376,10 @@ func (s *visibilityStore) ListClosedWorkflowExecutionsByType(request *manager.Li
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListOpenWorkflowExecutionsByWorkflowID(request *manager.ListWorkflowExecutionsByWorkflowIDRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListOpenWorkflowExecutionsByWorkflowID(
_ context.Context,
request *manager.ListWorkflowExecutionsByWorkflowIDRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
Filter(
Expand All @@ -378,7 +405,10 @@ func (s *visibilityStore) ListOpenWorkflowExecutionsByWorkflowID(request *manage
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListClosedWorkflowExecutionsByWorkflowID(request *manager.ListWorkflowExecutionsByWorkflowIDRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListClosedWorkflowExecutionsByWorkflowID(
_ context.Context,
request *manager.ListWorkflowExecutionsByWorkflowIDRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
Filter(elastic.NewTermQuery(searchattribute.WorkflowID, request.WorkflowID)).
Expand All @@ -403,7 +433,10 @@ func (s *visibilityStore) ListClosedWorkflowExecutionsByWorkflowID(request *mana
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListClosedWorkflowExecutionsByStatus(request *manager.ListClosedWorkflowExecutionsByStatusRequest) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListClosedWorkflowExecutionsByStatus(
_ context.Context,
request *manager.ListClosedWorkflowExecutionsByStatusRequest,
) (*store.InternalListWorkflowExecutionsResponse, error) {

boolQuery := elastic.NewBoolQuery().
Filter(elastic.NewTermQuery(searchattribute.ExecutionStatus, request.Status.String()))
Expand All @@ -427,7 +460,10 @@ func (s *visibilityStore) ListClosedWorkflowExecutionsByStatus(request *manager.
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, isRecordValid)
}

func (s *visibilityStore) ListWorkflowExecutions(request *manager.ListWorkflowExecutionsRequestV2) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ListWorkflowExecutions(
_ context.Context,
request *manager.ListWorkflowExecutionsRequestV2,
) (*store.InternalListWorkflowExecutionsResponse, error) {
p, err := s.buildSearchParametersV2(request)
if err != nil {
return nil, err
Expand All @@ -452,7 +488,10 @@ func (s *visibilityStore) ListWorkflowExecutions(request *manager.ListWorkflowEx
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, nil)
}

func (s *visibilityStore) ScanWorkflowExecutions(request *manager.ListWorkflowExecutionsRequestV2) (*store.InternalListWorkflowExecutionsResponse, error) {
func (s *visibilityStore) ScanWorkflowExecutions(
_ context.Context,
request *manager.ListWorkflowExecutionsRequestV2,
) (*store.InternalListWorkflowExecutionsResponse, error) {
ctx, cancel := newReadContext()
defer cancel()

Expand Down Expand Up @@ -549,7 +588,10 @@ func (s *visibilityStore) scanWorkflowExecutionsWithScroll(ctx context.Context,
return s.getListWorkflowExecutionsResponse(searchResult, request.Namespace, request.PageSize, nil)
}

func (s *visibilityStore) CountWorkflowExecutions(request *manager.CountWorkflowExecutionsRequest) (*manager.CountWorkflowExecutionsResponse, error) {
func (s *visibilityStore) CountWorkflowExecutions(
_ context.Context,
request *manager.CountWorkflowExecutionsRequest,
) (*manager.CountWorkflowExecutionsResponse, error) {
boolQuery, _, err := s.convertQuery(request.Namespace, request.NamespaceID, request.Query)
if err != nil {
return nil, err
Expand Down
Loading