-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add support for paravirtual RDMA network interface adapter type #1598
Conversation
Hi @cspnanda, Thank for your contribution to the project! 🎉 Before this pull request can be considered, please ensure that you provide as much detail as possible in the submission. Unfortunately, no detail was provided. In addition, we recommend that an enhancement issue is created to describe the use case and then linked to the issue in the pull request. This helps the maintainers understand the intent and prioritize reviews. It seems that the issue was created but not linked in the References with "Closes #xxxx". You will also need to accept the HashiCorp CLA and ensure your commits are signed-off using the same name and email. Ryan Johnson |
Hi @cspnanda, For the CLA, you'll need to configure git to match the name and email in GitHub. For example,
Also, it's recommend to add the following in the content in the body of your commit.
You'll need to amend your last commit after you update your git environment. Ryan |
This requires introduction in upstream Ryan |
e7713d6
to
088bba6
Compare
Hi @cspnanda, Thank you for your contribution to the project! 🎉 Before this pull request can be considered, please ensure that you provide as much detail as possible in the submission. Unfortunately, no detail was provided. Could you also link the issue in the References with "Closes #xxxx"? Ryan Johnson |
@tenthirtyam I have added Reference issue #1597 and the upstream issue vmware/govmomi#2766 is merged. |
Hi @cspnanda! 👋🏻 Could you please complete the remainder of the pull request template which is currently limited other than the Reference. This pull request and associated enhancement issue are tagged under the Ryan Johnson |
Hi @cspnanda, The project has recently Ryan Johnson |
Reminder: Hi @cspnanda, The project has recently Ryan Johnson |
I'll rebase this PR |
Signed-off-by: C S P Nanda <cspnanda@gmail.com>
Apply Oxford comma style formatting.
Apply Oxford comma style formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased @tenthirtyam
Updates `CHANGELOG.md` to include the feature provided in #1598.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
With VMware PVRDMA — the paravirtual RDMA device that takes advantage of any RoCE-capable hardware on an ESXi host — ESXi can support running workloads with high performance while still maintaining the flexibility offered by virtualization, including operational flexibility, better resilience, higher availability, and lifecycle management capabilities. This high performance is possible because PVRDMA allows for direct memory transfers (DMA) between guest memory to
the RoCE-capable hardware without CPU intervention. Using the RDMA protocol enables the potential for memory-to-memory zero-copy transfers between guests on two different hosts.
Release Note
resource/virtual_machine
: Add support for the PVRDMAvmxnet3vrdma
network interface adapter type. (#1598)References
Closes: #1597