Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add support for paravirtual RDMA network interface adapter type #1598

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

cspnanda
Copy link
Contributor

@cspnanda cspnanda commented Feb 19, 2022

Description

With VMware PVRDMA — the paravirtual RDMA device that takes advantage of any RoCE-capable hardware on an ESXi host — ESXi can support running workloads with high performance while still maintaining the flexibility offered by virtualization, including operational flexibility, better resilience, higher availability, and lifecycle management capabilities. This high performance is possible because PVRDMA allows for direct memory transfers (DMA) between guest memory to
the RoCE-capable hardware without CPU intervention. Using the RDMA protocol enables the potential for memory-to-memory zero-copy transfers between guests on two different hosts.

Release Note

resource/virtual_machine : Add support for the PVRDMA vmxnet3vrdma network interface adapter type. (#1598)

References

Closes: #1597

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 19, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added dependencies Type: Dependencies documentation Type: Documentation provider Type: Provider size/xs Relative Sizing: Extra-Small labels Feb 19, 2022
@tenthirtyam tenthirtyam added enhancement Type: Enhancement needs-review Status: Pull Request Needs Review labels Feb 19, 2022
@tenthirtyam
Copy link
Collaborator

tenthirtyam commented Feb 19, 2022

Hi @cspnanda,

Thank for your contribution to the project! 🎉

Before this pull request can be considered, please ensure that you provide as much detail as possible in the submission. Unfortunately, no detail was provided. In addition, we recommend that an enhancement issue is created to describe the use case and then linked to the issue in the pull request. This helps the maintainers understand the intent and prioritize reviews. It seems that the issue was created but not linked in the References with "Closes #xxxx".

You will also need to accept the HashiCorp CLA and ensure your commits are signed-off using the same name and email.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@tenthirtyam tenthirtyam added the waiting-response Status: Waiting on a Response label Feb 19, 2022
@github-actions github-actions bot removed the waiting-response Status: Waiting on a Response label Feb 19, 2022
@tenthirtyam tenthirtyam added this to the Research milestone Feb 19, 2022
@tenthirtyam tenthirtyam self-assigned this Feb 19, 2022
@tenthirtyam
Copy link
Collaborator

Hi @cspnanda,

For the CLA, you'll need to configure git to match the name and email in GitHub.

For example,

git config --global user.email cspnanda@gmail.com
git config --global user.name C S P Nanda

Also, it's recommend to add the following in the content in the body of your commit.

Signed-off-by: C S P Nanda <cspnanda@gmail.com>

You'll need to amend your last commit after you update your git environment.

Ryan

@tenthirtyam tenthirtyam added the area/vm Area: Virtual Machines label Feb 19, 2022
@tenthirtyam
Copy link
Collaborator

⚠️ Critical Reference: vmware/govmomi#2766

This requires introduction in upstream vmware/govmomi first and subsequent upgrade of the version used by this provider.

Ryan

@tenthirtyam tenthirtyam added the upstream/govmomi Upstream: vmware/govmomi label Feb 20, 2022
@tenthirtyam
Copy link
Collaborator

tenthirtyam commented Feb 20, 2022

@cspnanda cspnanda force-pushed the master branch 2 times, most recently from e7713d6 to 088bba6 Compare February 22, 2022 19:00
@tenthirtyam tenthirtyam added the area/networking Area: Networking label Feb 22, 2022
@tenthirtyam tenthirtyam changed the title Added Support of vrdma ethernet card Added support of vrdma ethernet card Feb 28, 2022
@tenthirtyam tenthirtyam added the waiting-response Status: Waiting on a Response label Feb 28, 2022
@tenthirtyam
Copy link
Collaborator

Hi @cspnanda,

Thank you for your contribution to the project! 🎉

Before this pull request can be considered, please ensure that you provide as much detail as possible in the submission. Unfortunately, no detail was provided. Could you also link the issue in the References with "Closes #xxxx"?

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@github-actions github-actions bot removed the waiting-response Status: Waiting on a Response label Feb 28, 2022
@cspnanda cspnanda closed this Mar 1, 2022
@cspnanda cspnanda reopened this Mar 1, 2022
@tenthirtyam tenthirtyam added the waiting-response Status: Waiting on a Response label Mar 1, 2022
@cspnanda
Copy link
Contributor Author

cspnanda commented Mar 1, 2022

@tenthirtyam I have added Reference issue #1597 and the upstream issue vmware/govmomi#2766 is merged.

@github-actions github-actions bot removed the waiting-response Status: Waiting on a Response label Mar 1, 2022
@tenthirtyam
Copy link
Collaborator

tenthirtyam commented Mar 1, 2022

Hi @cspnanda! 👋🏻

Could you please complete the remainder of the pull request template which is currently limited other than the Reference.

image

This pull request and associated enhancement issue are tagged under the backlog and will move into a future release milestone when ready. It will be dependent on a chore to update to the release of vmware/govmomi` that includes the upstream capability.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@tenthirtyam tenthirtyam added waiting-response Status: Waiting on a Response pending-closure Status: Pending Closure labels Jul 15, 2022
@tenthirtyam tenthirtyam modified the milestones: v2.3.0, Backlog / Triage Jul 15, 2022
@tenthirtyam tenthirtyam modified the milestones: Backlog / Triage, v2.3.0 Jul 26, 2022
@tenthirtyam tenthirtyam changed the title feat: Added support of vrdma ethernet card feat: Add support for ParaVirtualRDMA network interface adapter type Jul 26, 2022
@tenthirtyam
Copy link
Collaborator

Hi @cspnanda,

The project has recently vmware/govmomi to v0.29.0. Could you update your pull request to address the current conflicts?

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@github-actions github-actions bot removed the waiting-response Status: Waiting on a Response label Jul 30, 2022
@tenthirtyam tenthirtyam added waiting-response Status: Waiting on a Response and removed upstream/govmomi Upstream: vmware/govmomi do-not-merge Status: Draft, Do Not Merge labels Jul 30, 2022
@tenthirtyam
Copy link
Collaborator

Reminder:

Hi @cspnanda,

The project has recently vmware/govmomi to v0.29.0. Could you update your pull request to address the current conflicts?

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@github-actions github-actions bot removed the waiting-response Status: Waiting on a Response label Aug 7, 2022
@tenthirtyam tenthirtyam added the waiting-response Status: Waiting on a Response label Aug 7, 2022
@appilon
Copy link
Contributor

appilon commented Aug 8, 2022

I'll rebase this PR

@github-actions github-actions bot removed the waiting-response Status: Waiting on a Response label Aug 8, 2022
cspngo and others added 3 commits August 9, 2022 17:15
Signed-off-by: C S P Nanda <cspnanda@gmail.com>
Apply Oxford comma style formatting.
Apply Oxford comma style formatting.
@github-actions github-actions bot removed the dependencies Type: Dependencies label Aug 9, 2022
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased @tenthirtyam

@tenthirtyam tenthirtyam changed the title feat: Add support for ParaVirtualRDMA network interface adapter type feat: Add support for paravirtual RDMA network interface adapter type Aug 9, 2022
@tenthirtyam tenthirtyam removed the pending-closure Status: Pending Closure label Aug 9, 2022
@tenthirtyam tenthirtyam merged commit f879427 into hashicorp:main Aug 9, 2022
tenthirtyam pushed a commit that referenced this pull request Aug 9, 2022
Updates `CHANGELOG.md` to include the feature provided in #1598.
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Aug 7, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/networking Area: Networking area/vm Area: Virtual Machines documentation Type: Documentation enhancement Type: Enhancement provider Type: Provider size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for paravirtual RDMA network interface adapter type
5 participants