Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

enhance: Add extra_config_reboot_required to r/virtual_machine #1603

Merged
merged 3 commits into from
Jul 15, 2022
Merged

enhance: Add extra_config_reboot_required to r/virtual_machine #1603

merged 3 commits into from
Jul 15, 2022

Conversation

BeryJu
Copy link
Contributor

@BeryJu BeryJu commented Feb 25, 2022 •
edited by tenthirtyam
Loading

Description

Adds the optional extra_config_reboot_required argument which allows an update to extra_config without forcing a reboot of the virtual machine.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Release Note

Release note for CHANGELOG:

resource/virtual_machine: Add extra_config_reboot_required to configure if a VM should reboot when extra_config is changed. [GH-1603]

References

Closes #1070

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added provider Type: Provider size/xs Relative Sizing: Extra-Small labels Feb 25, 2022
@tenthirtyam tenthirtyam added this to the v2.2.0 milestone Feb 25, 2022
@tenthirtyam tenthirtyam added area/vm Area: Virtual Machines enhancement Type: Enhancement needs-review Status: Pull Request Needs Review area/guest Area: Guest Operating System labels Feb 25, 2022
@tenthirtyam
Copy link
Collaborator

tenthirtyam commented Feb 25, 2022 •
edited
Loading

I've added this to review for the v2.2.0 milestone. I've also linked the originating issue and updated the context for the future changelog update.

@tenthirtyam tenthirtyam self-requested a review February 25, 2022 12:57
tenthirtyam
tenthirtyam requested changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BeryJu,

Could you also include the changes to the r/vsphere_virtual_machine docs to include the extra_config_reboot_required?

For example:

extra_config_reboot_required: Allow the virtual machine to be rebooted when a change to extra_config occurs. Default: true.

vsphere/virtual_machine_config_structure.go Outdated Show resolved Hide resolved
vsphere/virtual_machine_config_structure.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title add extra_config_reboot_required Add extra_config_reboot_required to allow a reboot override on changes to extraConfig Feb 25, 2022
@github-actions github-actions bot added the documentation Type: Documentation label Feb 25, 2022
tenthirtyam
tenthirtyam reviewed Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, Jens!

I'll plan to test this after we release the v2.1.0 milestone.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@tenthirtyam tenthirtyam self-requested a review February 25, 2022 19:54
@tenthirtyam tenthirtyam added under-review and removed needs-review Status: Pull Request Needs Review labels Feb 25, 2022
@tenthirtyam tenthirtyam self-assigned this Feb 28, 2022
@tenthirtyam tenthirtyam changed the title Add extra_config_reboot_required to allow a reboot override on changes to extraConfig feat: Add extra_config_reboot_required to allow a reboot override on changes to extraConfig Mar 11, 2022
tenthirtyam
tenthirtyam approved these changes Mar 19, 2022
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this myself - worked nicely. 👍

@github-actions github-actions bot added size/m Relative Sizing: Medium size/xs Relative Sizing: Extra-Small and removed size/xs Relative Sizing: Extra-Small size/m Relative Sizing: Medium labels May 1, 2022
@BeryJu
Copy link
Contributor Author

BeryJu commented May 1, 2022

Hi, anything blocking this from being merged? I just rebased on main.

@tenthirtyam tenthirtyam assigned appilon and unassigned tenthirtyam May 1, 2022
@tenthirtyam tenthirtyam modified the milestones: v2.2.0, v2.3.0 Jun 6, 2022
@BeryJu
Copy link
Contributor Author

BeryJu commented Jul 12, 2022

Bumping this again, anything missing to get this merged?

@tenthirtyam
Copy link
Collaborator

@BeryJu, Please note that this is tagged for the v2.3.0 milestone as seen in the issue metadata.

image

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@BeryJu
Copy link
Contributor Author

BeryJu commented Jul 12, 2022

@BeryJu, Please note that this is tagged for the v2.3.0 milestone as seen in the issue metadata.

image

Ryan Johnson Staff II Solutions Architect | VMware, Inc.

My bad, I didn't see the tag updates, thanks for the confirmation

@tenthirtyam tenthirtyam assigned tenthirtyam and unassigned appilon Jul 15, 2022
tenthirtyam
tenthirtyam approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Worked really well when tested. 🚀

@tenthirtyam tenthirtyam changed the title feat: Add extra_config_reboot_required to allow a reboot override on changes to extraConfig feat: Add extra_config_reboot_required to r/virtual_machine Jul 15, 2022
@tenthirtyam tenthirtyam merged commit b0e650a into hashicorp:main Jul 15, 2022
@BeryJu BeryJu deleted the extra_config_reboot_required branch July 15, 2022 17:54
tenthirtyam pushed a commit that referenced this pull request Jul 15, 2022
docs: Update CHANGELOG.md
fb7f42e 
Updates `CHANGELOG.md` to include the feature provided in #1603.
@tenthirtyam tenthirtyam changed the title feat: Add extra_config_reboot_required to r/virtual_machine enhance: Add extra_config_reboot_required to r/virtual_machine Jul 26, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
area/guest Area: Guest Operating System area/vm Area: Virtual Machines documentation Type: Documentation enhancement Type: Enhancement provider Type: Provider size/xs Relative Sizing: Extra-Small
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Make reboot on extraConfig change optional
4 participants
@BeryJu @hashicorp-cla @tenthirtyam @appilon