fix: parse_image_id: Process "docker build" output in reverse line order #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a custom dockerfile which installs Python modules using pip, the output will sometimes contain the line: Successfully built module_name Since this matches the regex, it causes the module name to be incorrectly identified as the image ID, which will cause kitchen-docker to fail the "docker run" as it will not have a valid Docker image ID. This commit processes the "docker build" output in reverse line order, which will ensure that the correct line is matched.
|
Thanks @terminalmage |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom dockerfile which installs Python modules using pip, the output will sometimes contain the line:
Since this matches one of the regexes in parse_image_id, it causes the module name to be incorrectly identified as the image ID, which will cause kitchen-docker to fail the "docker run" as it will not have a valid Docker image ID.
This commit processes the "docker build" output in reverse line order, which will ensure that the correct line is matched.
Check List