Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: parse_image_id: Process "docker build" output in reverse line order #400

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix: parse_image_id: Process "docker build" output in reverse line order #400

merged 1 commit into from
Jun 14, 2023

Commits on May 18, 2023

  1. fix: parse_image_id: Process "docker build" output in reverse line order 

    When using a custom dockerfile which installs Python modules using pip,
the output will sometimes contain the line:

Successfully built module_name

Since this matches the regex, it causes the module name to be
incorrectly identified as the image ID, which will cause kitchen-docker
to fail the "docker run" as it will not have a valid Docker image ID.

This commit processes the "docker build" output in reverse line order,
which will ensure that the correct line is matched.
    Erik Johnson committed May 18, 2023
    Configuration menu
    Copy the full SHA
    86ad9aa View commit details
    Browse the repository at this point in the history