static/extern keyword

[rsaill]

Trying to parse (with Clang.Ast.parse_file) and immediately print (with Clang.Printer.translation_unit) the following C program:

static int g1 = 0;
int g2 = 0;
extern int g3;

int bar(int p){
	static int s;
	s++;
	int l = 42;
	return (p + s + l);
}

I get

static int g1 = 0;
int g2 = 0;
int g3;

int bar(int p){
	int s;
	s ++;
	int l = 42;
	return (p + s) + l;
};

The keyword extern is missing for the variable g3 and static is missing for the variable s.

Ronan (alias n47).

[thierry-martinez]

Thank you for inaugurating github issues! This issue made me notice that storage classes worth being exposed as fields in Ast.Var and Ast.Function (they were only accessible via cursor_get_storage_class before). But, be warned that the printer is very incomplete: there is no code printer in clang as far as I know, the clangml printer is a small printer coded in OCaml mainly for internal purpose. Not that it would not worth completing it, but there will be many things to be completed in order to have a decent printer!

This should be fixed in #2: as soon as CI is happy, I will update the snapshot branch. (You may have a try to the branch fix.1.storage_class directly, but you need to bootstrap it first with ./bootstrap.sh.)

[thierry-martinez]

#2 is now merged and snapshot is updated (I have added a new binding Clang.ext_decl_get_storage_class because clang_Cursor_getStorageClass is not available with Clang 3.4 and 3.5; even if they are quite old versions, I try to keep them supported). Thanks!

[rsaill]

Thanks once again for your lightning fast answer and fix.
I have a (possibly unrelated) question though. If I opam pin git+https://github.com/thierry-martinez/clangml.git#snapshot to get your last changes, I observe changes in Clang__Attributes. For example the constructor Clang__Attributes.AlwaysInline has disappeared.
Is that expected?

[thierry-martinez]

Nice catch: no, it wasn't expected. It is now fixed in snapshot. Thank you very much!