Integer literals

[rsaill]

When parsing and printing the following program

const unsigned long x = 18446744073709551615UL;

I get

unsigned long const x = -1;

While this is correct (I think) due to implicit conversion, I was expecting the original literal to be printed back.
After a quick look at the code, I think that there is a missing optional argument ?signed somewhere in the printer.

Also, I tried to implement a suffix_of_integer_literal in the same spirit as radix_of_integer_literal to extract, for instance, the 'UL' suffix above.
However, I remarked that it does not work when the literal comes from a macro expansion and the macro is defined in another file.
In this case, your radix_of_integer_literal returns None.
Do you think that there is another way to get the radix and the suffix in the particular case?

[thierry-martinez]

Thank you very much for reporting this! These bugs should be fixed in #4: you may checkout the branch https://github.com/thierry-martinez/clangml/tree/fix.3.integer_literal and run ./bootstrap.sh before ./configure to test it.

The printer should now print integer literals with the expected suffix. Moreover, radix_of_integer_literal now works even if the literal comes from a macro. Here is the new code of radix_of_integer_literal if you want to adapt it for suffix_of_integer_literal:

  let radix_of_integer_literal (expr : t) : radix option =
    let cursor = Ast.cursor_of_node expr in
    let start = get_range_start (get_cursor_extent cursor) in
    let tu = cursor_get_translation_unit cursor in
    let tokens = tokenize tu (get_range start start) in
    if Array.length tokens >= 1 then
      Some (radix_of_string (get_token_spelling tu tokens.(0)))
    else
      None

[rsaill]

Fantastic! I can confirm that it works as expected now.

[thierry-martinez]

This issue (and the previous ones) are fixed in clangml release 4.8.0, which should appear in opam soon. Thank you for your contributions to this release!