Fix #3: integer literal printing and radix parsing #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsaill reported that ``` const unsigned long x = 18446744073709551615UL; ``` was printed as follows with `Clang.Printer`: ``` unsigned long const x = -1; ``` The printer now uses the signedness information to print integer literals. Moreover, `Clang.Expr.radix_of_integer_literal` did not work if the literal was defined in a macro: this is now fixed.
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsaill reported that
was printed as follows with
Clang.Printer:The printer now uses the signedness information to print integer
literals.
Moreover,
Clang.Expr.radix_of_integer_literaldid not work if theliteral was defined in a macro: this is now fixed.