Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(simulator): rename the diagnostic_convertor to scenario_simulator_v2_adapter. #643

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

xtk8532704
Copy link

@xtk8532704 xtk8532704 commented Oct 29, 2024

Description

rename diagnostic_converter to scenario_simulator_v2_adapter.

related PR of universe side: autowarefoundation/autoware.universe#9180
related Ticket: https://tier4.atlassian.net/browse/RT1-6863

Tests performed

https://evaluation.tier4.jp/evaluation/reports/9ac6d109-75aa-5585-bad2-7ebd7ec07c19?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtk8532704 xtk8532704 merged commit c803e0c into awf-latest Nov 12, 2024
10 checks passed
@xtk8532704 xtk8532704 deleted the xtk/metric-msg branch November 12, 2024 11:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants