Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: clean package xml #104

Open
wants to merge 3 commits into
base: tier4/universe
Choose a base branch
from

Conversation

VRichardJP
Copy link
Contributor

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#3606
autowarefoundation/autoware#346

Description

Better merged after autowarefoundation/autoware.universe#3606 to avoid missing dependencies.
Clean unused as described by autowarefoundation/autoware#3468
Eventually make build faster.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
@kenji-miyake kenji-miyake changed the title build: Clean package xml build: clean package xml May 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant