Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TSO follower proxy still effective after disabling it #8709

Closed
MyonKeminta opened this issue Oct 15, 2024 · 0 comments · Fixed by #8719
Closed

TSO follower proxy still effective after disabling it #8709

MyonKeminta opened this issue Oct 15, 2024 · 0 comments · Fixed by #8719
Assignees
Labels
affects-8.4 severity/critical type/bug The issue is confirmed as a bug.

Comments

@MyonKeminta
Copy link
Contributor

MyonKeminta commented Oct 15, 2024

Bug Report

What did you do?

In TiDB, while running any workload, enable TSO follower proxy and then disable it via system variable..

What did you expect to see?

The TSO follower proxy behavior stops after disabling TSO follower proxy

What did you see instead?

TSO follower looks still effective after disabling it. This can make the performace slighly lower than that before enabling it.

image
image

What version of PD are you using (pd-server -V)?

TiDB: a21d9ea
TiKV: 18546c296bc70e4abf2ab144b1f3048dbc47024e
PD: 982fa22

(The issue seems to be in pd client referenced by TiDB, not pd server).

@JmPotato JmPotato removed the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Oct 16, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in b70107e Oct 16, 2024
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2024
…ed (#8719) (#8721)

close #8709

Remove outdated follower connections after disabling the TSO follower proxy.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
affects-8.4 severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants