Restructure collecting of prometheus metrics and bump dependencies #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
force-pushed
the
collect-all
branch
from
3f308f4 to
096aae9
Compare
paulfantom
changed the title
nhudson
approved these changes
Oct 13, 2022
paulfantom
force-pushed
the
collect-all
branch
2 times, most recently
from
cd3e06e to
297efc3
Compare
paulfantom
changed the title
paulfantom
force-pushed
the
collect-all
branch
from
1647b99 to
73b01fe
Compare
paulfantom
force-pushed
the
collect-all
branch
2 times, most recently
from
655dc44 to
4f0da98
Compare
Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
paulfantom
force-pushed
the
collect-all
branch
from
4f0da98 to
d7e08d0
Compare
|
I think I found the main issues preventing merge of this PR:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR aims to reduce learning curve and simplify UX by configuring prometheus instances shipped with tobs to gather all PrometheusRules, ServiceMonitors, PodMonitors, and Probes that are injected into the cluster. This way the observability platform can collect data from the whole cluster.
To opt-out a resource from being used by prometheus shipped with tobs, you need to label it with
tobs/excludedlabel (value doesn't matter).This PR is also disabling scraping metrics using prometheus label mechanism and forcing users to use prometheus-operator CRs. This should prevent data duplication in larger clusters and align us closer to kube-prometheus project (jsonnet one). Feature can be re-enable if needed by the user.
Checklist