fig bug for imageID with more than one tags #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianjun1993
force-pushed
the
inplaceUpdate
branch
from
fe306ac to
066d6df
Compare
hex108
reviewed
Jan 29, 2021
| } else if err := json.Unmarshal([]byte(stateStr), &inPlaceUpdateState); err != nil { | ||
| klog.Warningf("Failed to unmarshal inPlaceUpdateState for pod %s/%s", | ||
| pod.Namespace, pod.Name) | ||
| //in this case, the pod is in updating? |
| } | ||
|
|
||
| //to find these container which will change in update and add they status before update | ||
| func getInPlaceUpdateStateJson(newPod, oldPod *corev1.Pod) error { |
There was a problem hiding this comment.
从getInPlaceUpdateStateJson 这个名字看应该是要返回一个 string，但这个函数实际做的事是给newPod加了一个annotation。可以把函数改成返回(string, error)，不用在这函数里给newPod设置annotation
| @@ -831,7 +832,7 @@ func (c *Controller) transformPodActions(tapp *tappv1.TApp, podActions map[strin | |||
| a, getPodFullName(pod), len(availablePods), minAvailablePods) | |||
| break | |||
| } | |||
| if instance, err := newInstance(tapp, p); err == nil { | |||
| if instance, err := newInstanceWithOldStatus(tapp, p, pod); err == nil { | |||
There was a problem hiding this comment.
这里改成下面的，会不会更好理解点？
if instance, err := newInstance(tapp, p); err == nil {
err = setInplaceUpdateAnnoation(instance, pod)
...
}
|
close it for because #71 is merged. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before updating, we find the containers will update and add their old status into the annotations of new pod。
When we find some containers that their new ImageID is same as the old and their image tag is different from the expect, we think the pod is in updating.