fix bug for image with more than one tags when create Tapp #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hex108
reviewed
Feb 3, 2021
pkg/tapp/controller.go
Outdated
| @@ -1241,6 +1243,10 @@ func setInPlaceUpdateCondition(kubeclient kubernetes.Interface, pod *corev1.Pod, | |||
|
|
|||
| // isUpdating returns true if kubelet is updating image for pod, otherwise returns false | |||
| func isUpdating(pod *corev1.Pod) bool { | |||
| isInPlaceUpdate := false | |||
| if stateStr, ok := pod.Annotations[InPlaceUpdateStateKey]; ok { | |||
| isInPlaceUpdate = (stateStr == "true") | |||
There was a problem hiding this comment.
这里 if (stateStr != "true") 直接就可以return false了
pkg/tapp/instance.go
Outdated
| @@ -42,6 +42,9 @@ const ( | |||
| // updateRetries is the number of Get/Update cycles we perform when an | |||
| // update fails. | |||
| updateRetries = 3 | |||
|
|
|||
| // InPlaceUpdateStateKey records whether instance is in inPlace-updating. | |||
| InPlaceUpdateStateKey string = "inPlace-update-state" | |||
There was a problem hiding this comment.
改成tkestack.io/inplace-update-state？
qianjun1993
force-pushed
the
inplaceUpdate-2
branch
2 times, most recently
from
0101ff7 to
f885c21
Compare
hex108
reviewed
Feb 3, 2021
pkg/tapp/instance.go
Outdated
| if ins.pod.Annotations == nil { | ||
| ins.pod.Annotations = map[string]string{} | ||
| } | ||
| ins.pod.Annotations[InPlaceUpdateStateKey] = "true" |
qianjun1993
force-pushed
the
inplaceUpdate-2
branch
from
f885c21 to
f21f011
Compare
qianjun1993
force-pushed
the
inplaceUpdate-2
branch
from
f21f011 to
60bd985
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.