Typo in netref.class_factory?

[pilcru]

While investigating the other issue I posted today, I came across this line in core.netref.py. I'm almost certain this is a typo, but I wasn't able to link it to an actual bug. It might have no impact at all given how it's used in protocol.netref_factory.py.

Here is the code:

if _module:
    if id_pack[0] != 0:
        ns["__class__"] = _module
    else:
        ns["__class__"] = getattr(_module, "__class__", None)

The test id_pack[0] != 0 does not make sense since id_pack[0] is the name_pack string. Instead I think it should be

if _module:
    if id_pack[2] == 0:
       ...

Then if the object to be netref-ed is a class (id_pack[2] == 0), we can directly use it rather than finding its base class first.

[comrumino]

Ah good catch! It was supposed to be used in the else statement. Without it, some use cases could result in infinite recursion.