Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

OneShotServer not terminating after client connection closed since release 4.0.0 #343

Closed
WilliamBruneau opened this issue Jul 26, 2019 · 1 comment
Closed

OneShotServer not terminating after client connection closed since release 4.0.0 #343

WilliamBruneau opened this issue Jul 26, 2019 · 1 comment

Comments

@WilliamBruneau
Copy link
Contributor

WilliamBruneau commented Jul 26, 2019 •
edited
Loading

With this simple server/client:

Server:

from rpyc.utils.server import OneShotServer
from rpyc.core import SlaveService

server = OneShotServer(SlaveService, hostname='localhost', port=4455)
server.start()

Client:

import rpyc

conn = rpyc.classic.connect('localhost', 4455)

Server terminates after client execution when using rpyc release 3.4.4 (expected behavior according to documentation: "A server that handles a single connection (blockingly), and terminates after that").
Starting from release 4.0.0, the server does not terminate after client execution.

I am not sure if it is just a documentation issue or unwanted behavior.
@WilliamBruneau WilliamBruneau mentioned this issue Jul 26, 2019
Merged
@WilliamBruneau
Copy link
Contributor Author

It seems that the bug was introduced by commit e80ee1c.
I have made a PR (#344) that fixes it.

YuvalEvron pushed a commit to weka/rpyc that referenced this issue Oct 27, 2019
Rebase onto upstream (#4)
03d1acc 
* Added warning to _remote_tb when the major version of local and remote mismatch (tomerfiliba-org#332)

* Added `include_local_version` to DEFAULT_CONFIG to allow for configurable security controls (e.g. `include_local_traceback`)

* Update readme.txt

* Added break to client process loop when everything is dead

* Increased chunk size to improve multi-client response time and throughput of large data tomerfiliba-org#329

* Improved test for response of client 1 while transferring a large amount of data to client 2

* Cleaned up coding style of test_service_pickle.py

* Updated issue template

* added vs code testing cfgs; updated gitignore venv

* Changed settings.json to use env USERNAME

* Name pack casted in _unbox to fix IronPython bug. Fixed tomerfiliba-org#337

* Fixed netref.class_factory id_pack usage per tomerfiliba-org#339 and added test cases

* Added .readthedocs.yml and requirements to build

* Make OneShotServer terminates after client connection ends

* Added unit test for OneShotServer. Fixed tomerfiliba-org#343

* Fixed 2.6 backwards incompatibility for format syntax

* Updated change log and bumped version --- 4.1.1

* Added support for chained connections which result in netref being passed to get_id_pack. Fixed tomerfiliba-org#346

* Added tests for get_id_pack

* Added a test for issue tomerfiliba-org#346

* Corrected the connection used to inspect a netref

* Refactored __cmp__ getattr

* Extended rpyc over rpyc unit testing and removed port parameter from TestRestricted

* Added comment explaining the inspect for intermediate proxy. Fixed tomerfiliba-org#346

* Improved docstring for serve_threaded to address when and when not to use the method. Done tomerfiliba-org#345

* Release 4.1.2

* Fixed versions referred to in security.rst

* link docs instead of mitre

* set up logging with a better formatter

* fix bug when proxy context-manager is being exited with an exception (#1)

* logging: add a rotating file log handler

* fix bug when proxy context-manager is being exited with an exception (#1)

* logging: add a rotating file log handler
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WilliamBruneau