Forked worker processes now inherit PATH from parent

[nicktrn]

Summary by CodeRabbit

• New Features

  • Enhanced process management for forked worker processes by ensuring they inherit the correct PATH settings from the parent process.

• Bug Fixes

  • Corrected the environment variable settings for child processes to improve execution context and resource accessibility.

[changeset-bot]

🦋 Changeset detected

Latest commit: 6e7abf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
trigger.dev	Patch
@trigger.dev/build	Patch
@trigger.dev/core	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/sdk	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@internal/redis-worker	Patch
@internal/zod-worker	Patch
@internal/testcontainers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request introduces modifications to the "trigger.dev" configuration and the TaskRunProcess class. It adds a patch that ensures forked worker processes inherit the correct PATH environment variable from their parent process, enhancing process management. The initialize method within the TaskRunProcess class is updated to include the PATH in the environment setup for child processes, ensuring they operate with the appropriate execution context.

Changes

File Path	Change Summary
.changeset/warm-keys-perform.md	Introduced a patch for "trigger.dev" configuration to set the parent PATH for forked worker processes.
packages/cli-v3/src/executions/taskRunProcess.ts	Modified the initialize method in TaskRunProcess to include the PATH environment variable in the fullEnv object for child processes.

Possibly related PRs

• Fix dotenv overrides for dev runs #1388: The changes in this PR also involve the "trigger.dev" configuration and focus on environment variable management, which is closely related to the modifications made in the main PR regarding the handling of the PATH environment variable for forked processes.

Suggested reviewers

• matt-aitken

🐰 In the meadow, where bunnies play,
A patch was made to brighten the day.
Forked processes now inherit with grace,
The PATH from their parent, in the right place.
Hopping along, with tasks to run,
Our code is better, oh what fun! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.changeset/warm-keys-perform.md (1)

4-5: Consider enhancing the changeset description.

While the description is clear, it would be more helpful to include:

• The problem being solved (why PATH inheritance was an issue)
• The impact of this fix (what improves after this change)
• Any related changes (e.g., the TaskRunProcess modifications)

Consider expanding the description like this:

-Set parent PATH on forked worker processes
+Fixes worker process PATH inheritance to ensure child processes have access to the same
+executable paths as their parent process. This resolves potential command resolution
+issues in forked workers by properly inheriting the parent's PATH environment variable
+through the TaskRunProcess initialization.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between da08e50 and 6e7abf4.

📒 Files selected for processing (2)

• .changeset/warm-keys-perform.md (1 hunks)
• packages/cli-v3/src/executions/taskRunProcess.ts (1 hunks)

🔇 Additional comments (3)

.changeset/warm-keys-perform.md (1)

1-3: LGTM on version bump choice!

The patch version bump is appropriate for this type of fix, as it maintains backward compatibility while fixing the PATH inheritance behavior.

packages/cli-v3/src/executions/taskRunProcess.ts (2)

124-127: Verify completeness of environment inheritance.

The current implementation inherits only specific environment variables. Consider whether other critical environment variables should also be inherited for proper process execution.

Let's check for other environment variable usage in the codebase:

---

126-126: 🛠️ Refactor suggestion

Ensure consistent PATH inheritance across platforms.

The addition of PATH inheritance is crucial for command resolution in child processes. However, consider the following platform-specific considerations:

1. On Windows, the environment variable is case-insensitive ('Path' vs 'PATH')
2. Some systems might use additional path-like variables (e.g., 'Path' on Windows)

Let's verify the PATH handling across platforms:

Consider making the PATH inheritance more robust:

-      PATH: process.env.PATH,
+      PATH: process.env.PATH || process.env.Path || '',