Prevent stuck runs after duplicate dependency resume messages

[nicktrn]

In rare cases the platform could retry sending dependency resume messages even if the task run correctly received it. To deal with this, newly deployed tasks will now discard non-current dependency resumes.

Summary by CodeRabbit

• New Features

  • Improved handling of duplicate dependency resume messages during task deployment, reducing log clutter.
  • Enhanced logging and error handling for task execution, particularly when resuming from a paused state.

• Bug Fixes

  • Fixed issues related to task completion verification, ensuring accurate execution flow.

[changeset-bot]

🦋 Changeset detected

Latest commit: 57ef6b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
trigger.dev	Patch
@trigger.dev/build	Patch
@trigger.dev/core	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/sdk	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@internal/redis-worker	Patch
@internal/zod-worker	Patch
@internal/testcontainers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request introduces modifications to the "trigger.dev" configuration and the ProdWorker class in the deploy-run-controller.ts file. The changes focus on improving the handling of duplicate dependency resume messages during task deployment, ensuring that repeated messages are ignored to reduce log clutter. Additionally, the handler for the RESUME_AFTER_DEPENDENCY message is updated to include an attemptId parameter and enhanced logging for better debugging and error handling.

Changes

File Path	Change Summary
.changeset/lovely-swans-pump.md	Introduces a patch for handling duplicate dependency resume messages in deployed tasks, filtering out repeated messages.
packages/cli-v3/src/entryPoints/deploy-run-controller.ts	Updates ProdWorker class to modify RESUME_AFTER_DEPENDENCY handler to include attemptId, enhancing logging and error handling.

Possibly related PRs

• Add acking to RESUME_AFTER_DEPENDENCY message to the coordinator #1313: Adds an acknowledgment mechanism to the RESUME_AFTER_DEPENDENCY message, directly related to the handling of dependency resume messages.
• Prioritize finishing waited runs #1375: Modifies the enqueueing process for resumed runs to ensure correct prioritization, aligning with the main PR's focus.
• Pass init output to all error handlers #1441: Enhances error handling by passing initialization output to error handlers, relating to task execution clarity.
• Forked worker processes now inherit PATH from parent #1448: Addresses inheritance of the PATH environment variable for forked processes, indirectly relating to task execution context.

Suggested reviewers

• ericallam

🐇 In the meadow where bunnies play,
A patch was made to clear the way.
Duplicate messages, no longer a fuss,
With logs now tidy, it's a plus!
So hop along, let tasks resume,
In the world of code, there's always room! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6313db6 and 57ef6b6.

📒 Files selected for processing (2)

• .changeset/lovely-swans-pump.md (1 hunks)
• packages/cli-v3/src/entryPoints/deploy-run-controller.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• .changeset/lovely-swans-pump.md

🔇 Additional comments (4)

packages/cli-v3/src/entryPoints/deploy-run-controller.ts (4)

588-596: Proper Handling of RESUME_AFTER_DEPENDENCY with Added attemptId Parameter

The updated handler includes the attemptId parameter and enhances logging, which improves debugging and traceability.

---

627-636: Robust Null Check for firstCompletion

Adding a null check for firstCompletion ensures that the code safely handles cases where the completions array may be empty, preventing potential runtime errors.

---

639-651: Validation of Task Replay State Consistency

The additional check for friendlyId mismatch strengthens the validation logic, ensuring that the task resumption aligns with the expected replay state. This enhances reliability by preventing unintended behavior due to stale or mismatched data.

---

656-668: Validation of Batch Replay State Consistency

Similarly, verifying the runFriendlyIds in the batch replay ensures that only the correct tasks are resumed. This check improves the integrity of the batch processing by avoiding issues caused by incorrect or outdated replay information.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

@trigger.dev/react-hooks

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1459

@trigger.dev/build

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1459

trigger.dev

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1459

@trigger.dev/sdk

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1459

@trigger.dev/core

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1459

commit: 57ef6b6