Changing minification defaults

[ctron]

Some folks would prefer to keep minification off by default. So, let's figure out how we can get there, in a reasonable way.

Right now, minification is on by default for --release builds. It can be disabled on a "per asset" setting via the data-no-minification attribute. Or globally, using --no-minification.

In order to make this a conscious decision, the idea is to not enable minification based on the --release flag, starting with Trunk 0.20.x, as this will be a breaking change.

The question is, how is this supposed to work? Ideally, there would some "release" profile where one could configure this. However, my feeling is that adding profiles right now is a bit too much.

I think it makes sense to have a global switch for minification (e.g. --minification, -M, build.minification). I can have three values: Never, OnRelease, Always. Internally it is Option<Minification> and defaults to None. A value of None will translate to Never when evaluating. That way we can override from the command line.

An asset can still opt-out of the while process using data-no-minification.

If possible (need to check with clap), passing just --minification (-M) would lead to Minification::Always. -M never would override any setting in Trunk.toml.

I think this way we should be able to have minification off by default, can easily turn it on from the command line or config, and still can have assets opt-out if required. Any thoughts?

Also see:

• Minification removing wasmbindgen getters #761
• Minification is breaking CSS #758
• Minification of some javascript is breaking some functionality. #750