feat: allow better control over minification, default to off #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a central minification state for the build. It also adds that check to all assets, and adds a local override to more asset types.
ctron
force-pushed
the
feature/default_to_off_1
branch
2 times, most recently
from
3010878 to
abf2026
Compare
BREAKING-CHANGE: This changes the default behavior of minification to always off. It also drops the --no-minification argument in favor of a `--minify <value>` option. closes trunk-rs#774
ctron
force-pushed
the
feature/default_to_off_1
branch
from
abf2026 to
da9d4aa
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #774