Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New name - new life #105

Closed
AlexMost opened this issue Mar 27, 2018 · 13 comments
Closed

New name - new life #105

AlexMost opened this issue Mar 27, 2018 · 13 comments

Comments

@AlexMost
Copy link
Member

Issue - #104
So we need to decide how we should rename this project, to avoid legal infringement.

My thoughts about the new name (can be discussed here also):

  • short (3 - 5 characters).
  • does not contain translation, localization, i18n in its name.
  • there should be no existing trademark with that name.
  • available package name on the npm.

Feel free to suggest your ideas @MrOrz @vharitonsky @Alxpy @erickwilder

@oleksandr-kuzmenko
Copy link
Member

oleksandr-kuzmenko commented Mar 27, 2018

  • owlf

@erickwilder
Copy link
Contributor

@Alxpy What is the reasoning behind this name choice?

After thinking a little I came up with ttag as my first suggestion.

Rationale:

The library is defined as Modern javascript i18n localization library based on es6 tagged templates and the good old GNU gettext. It also makes use of the t tag to mark translatable text. I usually prefer names that put function ahead of style (e.g: webpack: the name clearly demonstrate the intents of the package vs grunt which requires a bit of explanation about what the tool actually does)

It also makes things compact when thinking about its design and usability by third party projects:

import {t, ngettext, msgid} from 'ttag'

And finally, it respects the rule established by @AlexMost 😄


ℹ️ Further research for possible trademarks has to be made but so far I couldn't find any blockers.

@AlexMost
Copy link
Member Author

AlexMost commented Apr 12, 2018

@erickwilder nice suggestion. @Alxpy, @MrOrz what do you think?

@oleksandr-kuzmenko
Copy link
Member

@erickwilder owlf - just random name that satisfies the rules

@AlexMost @erickwilder LGTM

@MrOrz
Copy link
Contributor

MrOrz commented Apr 16, 2018

ttag looks really nice!

How does it pronounce? "tea-tag"?

Maybe we can use a teabag tag hanging on the edge of a mug as a logo :P

@erickwilder
Copy link
Contributor

erickwilder commented Apr 24, 2018

Any other suggestions? Or should we go forward with this one?

@AlexMost
Copy link
Member Author

AlexMost commented Apr 25, 2018

@erickwilder I think ttag is good, we can take that one. So, basically now we need:

  1. Create/Rename new github org + repository.
  2. Fix docs.
  3. Create npm packages.
  4. Fix docs.
  5. Register and use new domain ttag.js.org for the project's main page.

@erickwilder
Copy link
Contributor

Okay, I can start working on patching the docs (and perhaps patching any npm publishing scripts).

All the rest I think is better if the current repo owners take care of.


Side note: I really liked @MrOrz idea for the logo. What about making everything based on open source and use some openclipart.org's assets for that?

I've found this one quite good for a starting point.
https://openclipart.org/detail/293011/tea-bag-in-cactus-cowboy-bold-stroke-icon-style

Since remixes are allowed we might play a bit with colors (or not)

@AlexMost
Copy link
Member Author

@erickwilder sounds great. Sorry for the delayed responses, currently I am a little bit overloaded at work... If you have a chance to help with docs I will really appreciate. I have already reserved ttag package on npm - https://www.npmjs.com/package/ttag. Hope will have more time in the next week to close this issue.

@erickwilder
Copy link
Contributor

erickwilder commented Apr 27, 2018

It would be nice to reservebabel-plugin-ttag and ttag-cli on NPM as well.

@erickwilder
Copy link
Contributor

@AlexMost

I've been thinking a little about the transition process from the old to the new name and it would be good (for anyone using the library/babel plugin) to start warning users that a future change will be backward incompatible. For that I thought about the following:

  1. Add a section to the documentation instructing users how to proceed with the migration from c-3po to ttag; as far I can think of this will include: installing the new npm packages, replacing imports from c-3po to ttag and nothing more than that. If I'm missing something, we can always patch it 😄
  2. Release ASAP a patch version including a warning to state that the library will be deprecated in favor of the new name; this warning should include a link to the article described above.
  3. After publishing the new npm package, release a minor version to the current package on NPM adding deprecation warnings to almost all function calls/build with the babel plugin, stating that the old package will no longer receive updates (point to the new package name)

If you have any other strategies in mind, please share.

@AlexMost
Copy link
Member Author

AlexMost commented May 2, 2018

@erickwilder sounds ok, will release the patch version with warnings ASAP. I will have more time on this week to finish the transition.

@AlexMost
Copy link
Member Author

AlexMost commented May 7, 2018

So, the transition process is almost done:

  • published ttag, babel-plugin-ttag, ttag-cli packages with all tests and docs fixes.
  • Added some notes about new name migration to projects README's
  • created c-3po-support branches in repositories for bugfixes to the old name packages.
  • Added some fixes to documentation.
  • Added deprecation warnings in patch versions for c-3po and babel-plugin-c-3po packages.

Let me know If I have missed something.

@erickwilder thanks for your help :)

Future plans:

  1. Create new projects website with documentation on ttag.js.org. It can be implemented in a separate repository and c-3po.js.org can refer to the new site. ttag.js.org #108
  2. Think about the logo, I think every project needs that - ttag logo #109

@AlexMost AlexMost closed this as completed May 7, 2018
AlexMost added a commit to AlexMost/js.org that referenced this issue Aug 8, 2018
Due to this issue ttag-org/ttag#105 we decided to rename our library from `c-3po` to `ttag`. We still want to keep old links to c-3po.js.org alive.

So couple of things are going on here:

1. Changing current c-3po.js.org location
2. Adding new domain name for ttag.js.org

Thanks for understanding, sorry for the extra work with the same domain
serjshevchenko pushed a commit to serjshevchenko/ttag that referenced this issue Dec 21, 2020
koa-body is vulnerable to arbitrary file read. The vulnerability exists as it is possible to copy a file that exists outside of the web server's scope, into the `/public` directory which can be publicly read.
yargs-parser is vulnerable to prototype pollution. The attack exists as it does not properly sanitize the key value provided by users, allowing the malicious properties of Object.prototype to be parsed or modified using a` __proto__` payload.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants