toml: allow inline comments in multiline arrays #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbacquey
requested changes
Sep 13, 2023
previously, if you had comments on individual items in a multiline array, e.g. ```toml children = [ "michael", "gob", # i don't care too much for this one "lindsay", ] ``` topiary would confusingly move the comment _below_ the element it was placed next to- ```toml children = [ "michael", "gob", # i don't care too much for this one "lindsay", ] ``` which can destroy the intent of the comment. this rule update now preserves inline comments and won't insert a linebreak after a separator if followed by one.
pjjw
force-pushed
the
pjjw/toml-allow-multiline-array-inline-comments
branch
from
0d22c01 to
12fb7e1
Compare
|
@nbacquey thanks for the pointers! let me know if i've addressed comments to satisfaction. |
nbacquey
approved these changes
Sep 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, if you had comments on individual items in a multiline
array, e.g.
topiary would confusingly move the comment below the element it was
placed next to-
which can destroy the intent of the comment. this rule update now
preserves inline comments and won't insert a linebreak after a separator
if followed by one.