toml: enforce final (oxford) comma in multiline arrays, remove from singleline arrays #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjjw
force-pushed
the
pjjw/toml-array-final-commas
branch
from
6f000f4 to
edbafa6
Compare
|
I have the impression this PR is somewhat mixed up with #624, could you un-entangle those two? |
…ingleline arrays this is more a preference, but it comes from a learned (python) annoyance- if you want to keep a set of things in sorted order, then every time the last item changes you have to go in and pick around the commas. in python it's a lot worse due to implicit string coercion, this is thankfully just illegal in toml, but still feels a good move for consistency and ease of sorting.
pjjw
force-pushed
the
pjjw/toml-array-final-commas
branch
from
edbafa6 to
96fb78f
Compare
@nbacquey it was, mostly because preserving the comment newline behavior while also adding trailing commas is an additional third thing that takes different queries. now that #624 is landed, i've rebased off main, so this should be a proper isolated diff now. |
nbacquey
approved these changes
Sep 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is more a preference, but it comes from a learned (python)
annoyance- if you want to keep a set of things in sorted order, then
every time the last item changes you have to go in and pick around the
commas. in python it's a lot worse due to implicit string coercion,
this is thankfully just illegal in toml, but still feels a good move for
consistency and ease of sorting.