Introduce unique annotation #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
flyingsilverfin
requested changes
Mar 29, 2023
| | RELATES type ( AS type )? | ||
| | PLAYS type_scoped ( AS type )? | ||
| | VALUE value_type | ||
| | REGEX STRING_ | ||
| | TYPE label_any | ||
| ; | ||
|
|
||
| annotations_owns : ( ANNOTATION_KEY )? ( ANNOTATION_UNIQUE )? ; |
There was a problem hiding this comment.
@krishnangovindraj raised good point about order indendence:
OWNS type ( AS type )? (annotation_owns*)
annotation_owns = ANNOTATION_KEY | ANNOTATION_UNIQUE | ANNOTATION_CARD ...
note that now each one is optional independently and the rule is written in singular form.
| private final TypeVariable attributeType; | ||
| private final TypeVariable overriddenAttributeType; | ||
| private final boolean isKey; | ||
| private final List<Annotation> annotations; | ||
| private final Annotation uniqueness; |
There was a problem hiding this comment.
We don't want to group annotations into super-types of annotations in the language for validation/restriction purposes.
flyingsilverfin
force-pushed
the
unique-annotation
branch
from
8c6290e to
98014d3
Compare
flyingsilverfin
force-pushed
the
unique-annotation
branch
4 times, most recently
from
564aa5f to
8029783
Compare
flyingsilverfin
force-pushed
the
unique-annotation
branch
from
8029783 to
ec17bdf
Compare
flyingsilverfin
approved these changes
May 3, 2023
dmitrii-ubskii
added a commit
that referenced
this pull request
May 23, 2023
## What is the goal of this PR? We generalise the annotation syntax and parsing to be able to handle a new type of annotation: the `@unique` annotation, which is available only on the owns constraint: `define person sub entity, owns email @unique;` The `@unique` annotation has been introduced first in TypeQL Java in #273. ## What are the changes implemented in this PR? We update the pest grammar used in the Rust parser to mirror the changes in TypeQL Java, and adjust the parser visitors to match. A few drive-by fixes: - mild refactoring prompted by Clippy; - replaced usage of deprecated `chrono` `NaiveDateTime` builders with up-to-date variants.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We generalise the annotation syntax and parsing to be able to handle a new type of annotation: the
@uniqueannotation, which is available only on theownsconstraint:This annotation indicates that any
emails a person owns must be unique to that person. It does not place any restrictions on the number of emails any given person may own.The language builder API has also been updated to use a generalised form of any number of annotations, rather than having a particular boolean per annotation type (now, pass annotation
UNIQUEorKEYinstead of booleans).What are the changes implemented in this PR?
annotations_ownsin the grammarannotations:@keybecomes anannotation, as does the new@uniqueannotationsin the grammar and the language builders