Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding a linker.d file for AppKernels #57

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

ryanrath
Copy link
Contributor

Description

This new file contains the AppKernels specific entry that was removed from
XDMoD's linker.json file.

Motivation and Context

So that this module will work w/ XDMoD's linker.php when installed.

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This new file contains the AppKernels specific entry that was removed from
XDMoD's `linker.json` file.
@jtpalmer jtpalmer modified the milestones: v8.1.0, 8.1.0 Mar 12, 2019
@jtpalmer
Copy link
Contributor

Just mentioning ubccr/xdmod#847 for reference.

@jtpalmer
Copy link
Contributor

Also need to add the linker file in build.json.

This is so that the new `linker.d/appkernels.json` file is included in the build
for the appkernels module.
@ryanrath ryanrath requested a review from jtpalmer March 12, 2019 13:30
@ryanrath ryanrath merged commit 7e2f1cb into ubccr:xdmod8.1 Mar 12, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants