Clean up linker.php #847
Merged
Clean up linker.php #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the `auto_loaders` section from `linker.json`. This was replaced by
`require_once("$baseDir/vendor/autoload.php")` in `linker.php`.
- Moved all entries in `linker.json::include_dirs` but `classes` to
`composer.json::autoload::classmap`.
- Updated composer.lock because composer.json was updated.
- All of the XSEDE entries in `linker.json::include_dirs` was moved to the XSEDE
modules `linker.d/xsede.json`.
jtpalmer
reviewed
Mar 11, 2019
jtpalmer
approved these changes
Mar 11, 2019
6 tasks
jtpalmer
pushed a commit
to jtpalmer/xdmod
that referenced
this pull request
Mar 12, 2019
- Removed the `auto_loaders` section from `linker.json`. This was replaced by
`require_once("$baseDir/vendor/autoload.php")` in `linker.php`.
- Moved all entries in `linker.json::include_dirs` but `classes` to
`composer.json::autoload::classmap`.
- Updated composer.lock because composer.json was updated.
- All of the XSEDE entries in `linker.json::include_dirs` was moved to the XSEDE
modules `linker.d/xsede.json`.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
auto_loaderssection fromlinker.json. This was replaced byrequire_once("$baseDir/vendor/autoload.php")inlinker.php.linker.json::include_dirsbutclassestocomposer.json::autoload::classmap.linker.json::include_dirswas moved to the XSEDEmodules
linker.d/xsede.json.NOTE: There are accompanying PR's for
supremmandappkernelsthat will need to be merged before those modules can be used w/ this PR.Motivation and Context
Now that
linkers.jsonis being read / processed byXdmodConfigurationit supports merging / extending etc.Tests performed
All automated tests
Types of changes
Checklist: