Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Uncaught JS exception when malformed URL is supplied #517

Closed
fluorumlabs opened this issue Nov 23, 2020 · 1 comment · Fixed by #565
Closed

Uncaught JS exception when malformed URL is supplied #517

fluorumlabs opened this issue Nov 23, 2020 · 1 comment · Fixed by #565
Assignees
@platosha
Labels
bug Something isn't working hilla Impact: Low Severity: Minor

Comments

@fluorumlabs
Copy link

Steps to reproduce:

  1. Navigate to https://cookbook.vaadin.com// (two trailing slashes)

Observe:

Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at Function.__createUrl (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:2399)
    at re.get __effectiveBaseUrl [as __effectiveBaseUrl] (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:2399)
    at re.__normalizePathname (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:2399)
    at re.__onNavigationEvent (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:2399)
    at re.setRoutes (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:2399)
    at Module.<anonymous> (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:2847)
    at i (vaadin-bundle-5a8c8610a0f26788a61d.cache.js:1)
    at vaadin-bundle-5a8c8610a0f26788a61d.cache.js:1
    at vaadin-bundle-5a8c8610a0f26788a61d.cache.js:1
@Haprog Haprog changed the title Uncought JS exception when malformed URL is supplied Uncaught JS exception when malformed URL is supplied Dec 8, 2020
@haijian-vaadin
Copy link
Contributor

haijian-vaadin commented Dec 8, 2020 •
edited
Loading

Fix the exception so that the process could continue

@platosha platosha self-assigned this Jan 29, 2021
platosha added a commit that referenced this issue Feb 12, 2021
@platosha
fix: avoid URL-confusing default pathname in baseUrl
808bf4f 
Fixes #517

When not set explicitly, the router constructor discovers `baseUrl`
using the `<base href>` value and initial document URL. However, only
the pathname from the discovered base URL was taken for the default
value of the `baseUrl` property. In case of initial pathname starting with
double slash `//`, such a value was then throwing `Invalid URL` error when
used as the URL constructor’s first argument.

This changes the default value discovery of `baseUrl`, so that it uses
an actual URL instead of only pathname to avoid throwing errors.
@platosha platosha mentioned this issue Feb 12, 2021
Merged
platosha added a commit that referenced this issue Feb 15, 2021
@platosha
fix: avoid URL-confusing default pathname in baseUrl (#565)
a550589 
Fixes #517

When not set explicitly, the router constructor discovers `baseUrl`
using the `<base href>` value and initial document URL. However, only
the pathname from the discovered base URL was taken for the default
value of the `baseUrl` property. In case of initial pathname starting with
double slash `//`, such a value was then throwing `Invalid URL` error when
used as the URL constructor’s first argument.

This changes the default value discovery of `baseUrl`, so that it uses
an actual URL instead of only pathname to avoid throwing errors.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@platosha platosha

Labels
bug Something isn't working hilla Impact: Low Severity: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid URL-confusing default pathname in baseUrl vaadin/router
3 participants
@platosha @fluorumlabs @haijian-vaadin