fix: avoid URL-confusing default pathname in baseUrl #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
When not set explicitly, the router constructor discovers
baseUrl
using the
<base href>
value and initial document URL. However, onlythe pathname from the discovered base URL was taken for the default
value of the
baseUrl
property. In case of initial pathname starting withdouble slash
//
, such a value was then throwingInvalid URL
error whenused as the URL constructor’s first argument.
This changes the default value discovery of
baseUrl
, so that it usesan actual URL instead of only pathname to avoid throwing errors.