Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

vaadin-router doesn't run in npm7 (node 15) #541

Closed
haijian-vaadin opened this issue Jan 29, 2021 · 1 comment · Fixed by #592
Closed

vaadin-router doesn't run in npm7 (node 15) #541

haijian-vaadin opened this issue Jan 29, 2021 · 1 comment · Fixed by #592
Labels

Comments

@haijian-vaadin
Copy link
Contributor

To reproduce:

  1. Install npm 7
  2. in the vaadin-router root directory, run npm install
  3. See the error messages
vaadin-router % npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: eslint@7.18.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^7.15.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! dev eslint-config-vaadin@"0.2.7" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@5.16.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^5.0.0" from eslint-config-vaadin@0.2.7
npm ERR!   node_modules/eslint-config-vaadin
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/haijian/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/haijian/.npm/_logs/2021-01-29T10_26_31_733Z-debug.log
@Haprog
Copy link
Contributor

Haprog commented Mar 12, 2021

Currently it works with npm 7 if you run:

npm install --legacy-peer-deps

Latest Yarn also works:

yarn install

Haprog added a commit that referenced this issue Mar 16, 2021
npm install was failing with npm 7 unless using the --legacy-peer-deps
flag. Remove dependency to old version of eslint-config-vaadin
and stylelint-config-vaadin while adapting the configs to try to keep
the rules mostly the same for now. We might consider using the latest
version of eslint-config-vaadin and stylelint-config-vaadin again when
we migrate away from bower and HTML Imports and maybe migrate
this repo to use TypeScript.

Fixes #541.
haijian-vaadin pushed a commit that referenced this issue Mar 16, 2021
npm install was failing with npm 7 unless using the --legacy-peer-deps
flag. Remove dependency to old version of eslint-config-vaadin
and stylelint-config-vaadin while adapting the configs to try to keep
the rules mostly the same for now. We might consider using the latest
version of eslint-config-vaadin and stylelint-config-vaadin again when
we migrate away from bower and HTML Imports and maybe migrate
this repo to use TypeScript.

Fixes #541.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants