fix: npm install with npm 7 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm install was failing with npm 7 unless using the --legacy-peer-deps flag. Remove dependency to old version of eslint-config-vaadin and stylelint-config-vaadin while adapting the configs to try to keep the rules mostly the same for now. We might consider using the latest version of eslint-config-vaadin and stylelint-config-vaadin again when we migrate away from bower and HTML Imports and maybe migrate this repo to use TypeScript. Fixes #541.
Haprog
commented
Mar 16, 2021
| @@ -222,7 +222,7 @@ class Resolver { | |||
| ? this.constructor.__createUrl( | |||
| this.baseUrl, | |||
| document.baseURI || document.URL | |||
| ).href.replace(/[^\/]*$/, '') | |||
There was a problem hiding this comment.
This was an unnecessary escape (complained by linter rule). Most characters don't need to be escaped inside a character group [].
Haprog
commented
Mar 16, 2021
| @@ -172,7 +172,7 @@ export class Router extends Resolver { | |||
| const baseHref = baseElement && baseElement.getAttribute('href'); | |||
| super([], Object.assign({ | |||
| // Default options | |||
| baseUrl: baseHref && Resolver.__createUrl(baseHref, document.URL).href.replace(/[^\/]*$/, '') | |||
There was a problem hiding this comment.
This was an unnecessary escape (complained by linter rule). Most characters don't need to be escaped inside a character group [].
haijian-vaadin
approved these changes
Mar 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm install was failing with npm 7 unless using the
--legacy-peer-depsflag. Remove dependency to old version of
eslint-config-vaadinand
stylelint-config-vaadinwhile adapting the configs to try to keepthe rules mostly the same for now. We might consider using the latest
version of
eslint-config-vaadinandstylelint-config-vaadinagain whenwe migrate away from bower and HTML Imports and maybe migrate
this repo to use TypeScript.
The problem was old versions of
eslintandstylelintdeclared as peer dependencies ofeslint-config-vaadinandstylelint-config-vaadinand we can't yet use newer versions ofeslint-config-vaadinandstylelint-config-vaadinbecause they have changed to support LitElement and TypeScript based projects and those configs don't work as is for vaadin-router which is still based on HTML Imports and doesn't use TS.Fixes #541.